Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enpass: 6.0.1.239 -> 6.5.1.723 #107020

Merged
merged 2 commits into from Dec 30, 2020
Merged

enpass: 6.0.1.239 -> 6.5.1.723 #107020

merged 2 commits into from Dec 30, 2020

Conversation

ewok-old
Copy link
Contributor

Motivation for this change

Enpass has not been updating for 2 years.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ewok-old
Copy link
Contributor Author

I forgot to add a reviewer. 😞

@guillaumekoenig could you please have a look on this? I added you as a maintainer in meta, because 'git blame' showed you as a a last committer here.

@guillaumekoenig
Copy link
Contributor

I forgot to add a reviewer. 😞

@guillaumekoenig could you please have a look on this? I added you as a maintainer in meta, because 'git blame' showed you as a a last committer here.

Haven't used NixOS in a year. Don't add me, add you as maintainer.

@WolfangAukang
Copy link
Contributor

WolfangAukang commented Dec 29, 2020 •
edited

Result of nixpkgs-review pr 107020 run on x86_64-linux 1

1 package built:
  • enpass

Working fine and changes LGTM

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/309

@thiagokokada
Copy link
Contributor

thiagokokada commented Dec 30, 2020 •
edited

Result of nixpkgs-review pr 107020 1

1 package built:
  • enpass

I don't have an account, but GUI seems to work fine.

@AndersonTorres AndersonTorres merged commit 854973e into NixOS:master Dec 30, 2020
@ewok-old ewok-old deleted the enpass branch January 11, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagokokada thiagokokada thiagokokada approved these changes

@WolfangAukang WolfangAukang WolfangAukang approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ewok-old @guillaumekoenig @WolfangAukang @nixos-discourse @thiagokokada @AndersonTorres @Janik-Haag