gitAndTools.git-when-merged: init at 1.2.0 #107012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Result of 1 package built:
|
raboof
reviewed
Dec 16, 2020
| @@ -0,0 +1,38 @@ | |||
| { stdenv, fetchFromGitHub, python }: | |||
There was a problem hiding this comment.
I'm not sure we want to add new dependencies on python (which is python2), does this tool also work with python3?
There was a problem hiding this comment.
Works fine with Python3! Thanks for catching that.
| sha256 = "0sw98gmsnd4iki9fx455jga9m80bxvvfgys8i1r2fc7d5whc2qa6"; | ||
| }; | ||
|
|
||
| buildInputs = [python]; |
There was a problem hiding this comment.
(I think we typically use spaces after brackets)
There was a problem hiding this comment.
fixed with nixfmt
|
|
||
| src = fetchFromGitHub { | ||
| owner = "mhagger"; | ||
| repo = "${pname}"; |
There was a problem hiding this comment.
Suggested change
| repo = "${pname}"; | |
| repo = pname; |
| src = fetchFromGitHub { | ||
| owner = "mhagger"; | ||
| repo = "${pname}"; | ||
| rev = "refs/tags/v${version}"; |
There was a problem hiding this comment.
maybe
Suggested change
| rev = "refs/tags/v${version}"; | |
| rev = version; |
There was a problem hiding this comment.
that works indeed!
DamienCassou
force-pushed
the
DamienCassou/git-when-merged
branch
from
0abcb7f
to
d5f9b8b
Compare
|
Result of 1 package built:
|
raboof
approved these changes
Dec 16, 2020
marsam
requested changes
Dec 16, 2020
pkgs/applications/version-management/git-and-tools/git-when-merged/default.nix
Outdated
Show resolved
Hide resolved
pkgs/applications/version-management/git-and-tools/git-when-merged/default.nix
Outdated
Show resolved
Hide resolved
pkgs/applications/version-management/git-and-tools/git-when-merged/default.nix
Show resolved
Hide resolved
DamienCassou
force-pushed
the
DamienCassou/git-when-merged
branch
from
d5f9b8b
to
ffcc723
Compare
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
and removed
10.rebuild-darwin: 0
labels
marsam
approved these changes
Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)