Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pappl: init at 1.0.0 #107009

Merged
merged 1 commit into from Dec 26, 2020
Merged

pappl: init at 1.0.0 #107009

merged 1 commit into from Dec 26, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 16, 2020 •
edited

Motivation for this change

been in the news recently, looks promising

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer force-pushed the add-pappl branch 2 times, most recently from 797f92e to f7871af Compare December 16, 2020 19:39
@jonringer
Copy link
Contributor Author

cc @marsam

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107009 run on x86_64-linux 1

1 package built:
  • pappl

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107009 run on x86_64-darwin 1

1 package failed to build:
  • pappl
3 warnings generated.
Compiling job-accessors.c...
In file included from device-usb.c:15:
In file included from ./device-private.h:17:
./base-private.h:43:13: warning: 'strlcpy' macro redefined [-Wmacro-redefined]
#    define strlcpy(dst,src,dstsize) _pappl_strlcpy(dst,src,dstsize)
            ^
/nix/store/r913a0b23i21r8y4x8kgx024gms9lvx9-Libsystem-osx-10.12.6/include/secure/_string.h:104:9: note: previous definition is here
#define strlcpy(dest, src, len)                                 \
        ^
In file included from dnssd.c:15:
In file included from ./pappl-private.h:19:
In file included from ./dnssd-private.h:18:
./base-private.h:43:13: warning: 'strlcpy' macro redefined [-Wmacro-redefined]
#    define strlcpy(dst,src,dstsize) _pappl_strlcpy(dst,src,dstsize)
            ^
/nix/store/r913a0b23i21r8y4x8kgx024gms9lvx9-Libsystem-osx-10.12.6/include/secure/_string.h:104:9: note: previous definition is here
#define strlcpy(dest, src, len)                                 \
        ^
dnssd.c:267:10: error: use of undeclared identifier 'kDNSServiceErr_DefunctConnection'; did you mean 'kDNSServiceFlagsShareConnection'?
    case kDNSServiceErr_DefunctConnection :
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         kDNSServiceFlagsShareConnection
/nix/store/r913a0b23i21r8y4x8kgx024gms9lvx9-Libsystem-osx-10.12.6/include/dns_sd.h:277:5: note: 'kDNSServiceFlagsShareConnection' declared here
    kDNSServiceFlagsShareConnection     = 0x4000,
    ^
1 warning and 1 error generated.
make[1]: *** [../Makedefs:72: dnssd.o] Error 1
make[1]: *** Waiting for unfinished jobs....
1 warning generated.
In file included from job-accessors.c:14:
In file included from ./pappl-private.h:19:
In file included from ./dnssd-private.h:18:
./base-private.h:43:13: warning: 'strlcpy' macro redefined [-Wmacro-redefined]
#    define strlcpy(dst,src,dstsize) _pappl_strlcpy(dst,src,dstsize)
            ^
/nix/store/r913a0b23i21r8y4x8kgx024gms9lvx9-Libsystem-osx-10.12.6/include/secure/_string.h:104:9: note: previous definition is here
#define strlcpy(dest, src, len)                                 \
        ^
1 warning generated.
1 warning generated.
make[1]: Leaving directory '/private/tmp/nix-build-pappl-1.0.0.drv-0/source/pappl'
make: *** [Makefile:28: all] Error 1

@jonringer
Copy link
Contributor Author

mac should have support, but I'll just mark linux only for now

@SuperSandro2000 SuperSandro2000 merged commit a76d69a into NixOS:master Dec 26, 2020
@jonringer jonringer deleted the add-pappl branch December 27, 2020 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @SuperSandro2000