Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ceph: enable aarch64-linux platform #108396

Merged
merged 1 commit into from Jan 7, 2021
Merged

ceph: enable aarch64-linux platform #108396

merged 1 commit into from Jan 7, 2021

Conversation

nagy
Copy link
Member

@nagy nagy commented Jan 4, 2021

Motivation for this change

On a Raspberry Pi 4, this command works:

NIXPKGS_ALLOW_UNSUPPORTED_SYSTEM=1 nix-build '<nixpkgs>' -A ceph

So lets enable the platform.

Notify Maintainers

cc @adevress @alexanderkjeldaas @johanot @krav

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from krav, adevress and johanot January 4, 2021 14:54
danieldk
danieldk approved these changes Jan 7, 2021
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have the hardware currently to build this, but ofborg builds this fine on AArch64, LGTM.

Thanks!

@danieldk danieldk merged commit 7b72e86 into NixOS:master Jan 7, 2021
@nagy nagy deleted the ceph-aarch64 branch January 9, 2021 12:08
@nagy nagy mentioned this pull request Jan 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

@krav krav Awaiting requested review from krav

@adevress adevress Awaiting requested review from adevress

@johanot johanot Awaiting requested review from johanot

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nagy @danieldk