Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tartube: 2.1.0 -> 2.3.042 #108412

Merged
merged 1 commit into from Jan 5, 2021
Merged

tartube: 2.1.0 -> 2.3.042 #108412

merged 1 commit into from Jan 5, 2021

Conversation

ryneeverett
Copy link
Contributor

Motivation for this change
  • Add new ffmpeg dependency.
  • Update patch since gi was renamed pgi.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ryneeverett
tartube: 2.1.0 -> 2.3.042
905e3ba 
- Add new ffmpeg dependency.
- Update patch since gi was renamed pgi.
@ofborg ofborg bot requested review from mkg20001 and luc65r January 4, 2021 18:26
@fabaff
Copy link
Member

fabaff commented Jan 5, 2021

Result of nixpkgs-review pr 108412 1

1 package built:
  • tartube

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108412 run on x86_64-linux 1

1 package built:
  • tartube

@SuperSandro2000 SuperSandro2000 merged commit 2fb357b into NixOS:master Jan 5, 2021
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 108412 run on x86_64-darwin 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkg20001 mkg20001 Awaiting requested review from mkg20001

@luc65r luc65r Awaiting requested review from luc65r

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ryneeverett @fabaff @SuperSandro2000