Result of nixpkgs-review pr 108388 1

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108388 run on x86_64-linux 1

@SuperSandro2000 I forced-push squashing your proposed change. Please take a look at it.

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108388 run on x86_64-darwin 1

Oh, good. I'll research how to do it.

Oh, good. I'll research how to do it.

You should probably create a wrapper here to make sure that valgrind can be found even if it's not installed globally or in a local profile.

I'll look very dumb but I did not find out how to do this. Do you have an example or documentation I could take look at?

you basically want to use makeWrapper for that. The bash-code in a post-install hook may look like this then:

/* ... */ {
  nativeBuildInputs = [ makeWrapper ];
  postInstall = ''
    wrapProgram $out/bin/cargo-valgrind --prefix PATH : ${stdenv.lib.makeBinPath [ valgrind ]}
  '';
}

It kinda work. The valgrind is not installed ... dunno why.

error: valgrind executable not found in `PATH` (No such file or directory (os error 2))