Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.autobahn: 20.7.1 -> 20.12.3 #108390

Merged
merged 1 commit into from Jan 4, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Jan 4, 2021

Motivation for this change

Update to latest upstream release 20.12.3.

This fixes CVE-2020-35678 -> Upstream change.

Change log: https://autobahn.readthedocs.io/en/latest/changelog.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff
Copy link
Member Author

fabaff commented Jan 4, 2021

Result of nixpkgs-review pr 108390 1

1 package failed to build:
  • grab-site
28 packages built:
  • buildbot (python38Packages.buildbot)
  • buildbot-full (python38Packages.buildbot-full)
  • buildbot-ui (python38Packages.buildbot-ui)
  • gnome-keysign
  • magic-wormhole (python38Packages.magic-wormhole)
  • python37Packages.autobahn
  • python37Packages.buildbot
  • python37Packages.buildbot-full
  • python37Packages.buildbot-ui
  • python37Packages.channels
  • python37Packages.channels-redis
  • python37Packages.daphne
  • python37Packages.magic-wormhole
  • python37Packages.magic-wormhole-mailbox-server
  • python37Packages.python-binance
  • python38Packages.autobahn
  • python38Packages.channels
  • python38Packages.channels-redis
  • python38Packages.daphne
  • python38Packages.magic-wormhole-mailbox-server
  • python38Packages.python-binance
  • python39Packages.autobahn
  • python39Packages.channels
  • python39Packages.channels-redis
  • python39Packages.daphne
  • python39Packages.magic-wormhole
  • python39Packages.magic-wormhole-mailbox-server
  • python39Packages.python-binance

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108390 run on x86_64-linux 1

1 package failed to build and are new build failure:
  • grab-site: log was empty
28 packages built:
  • buildbot (python38Packages.buildbot)
  • buildbot-full (python38Packages.buildbot-full)
  • buildbot-ui (python38Packages.buildbot-ui)
  • gnome-keysign
  • magic-wormhole (python38Packages.magic-wormhole)
  • python37Packages.autobahn
  • python37Packages.buildbot
  • python37Packages.buildbot-full
  • python37Packages.buildbot-ui
  • python37Packages.channels
  • python37Packages.channels-redis
  • python37Packages.daphne
  • python37Packages.magic-wormhole
  • python37Packages.magic-wormhole-mailbox-server
  • python37Packages.python-binance
  • python38Packages.autobahn
  • python38Packages.channels
  • python38Packages.channels-redis
  • python38Packages.daphne
  • python38Packages.magic-wormhole-mailbox-server
  • python38Packages.python-binance
  • python39Packages.autobahn
  • python39Packages.channels
  • python39Packages.channels-redis
  • python39Packages.daphne
  • python39Packages.magic-wormhole
  • python39Packages.magic-wormhole-mailbox-server
  • python39Packages.python-binance

@fabaff
Copy link
Member Author

fabaff commented Jan 4, 2021

The blocker seems to be lmdb:

Executing setuptoolsBuildPhase
py-lmdb: Using bundled liblmdb with py-lmdb patches; override with LMDB_FORCE_SYSTEM=1 or LMDB_PURE=1.
sh: /usr/bin/patch: not found
Traceback (most recent call last):
  File "nix_run_setup", line 8, in <module>
    exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\\r\\n', '\\n'), __file__, 'exec'))
  File "setup.py", line 119, in <module>
    raise Exception('Applying patch failed')
Exception: Applying patch failed

@SuperSandro2000
Copy link
Member

The blocker seems to be lmdb:

Executing setuptoolsBuildPhase
py-lmdb: Using bundled liblmdb with py-lmdb patches; override with LMDB_FORCE_SYSTEM=1 or LMDB_PURE=1.
sh: /usr/bin/patch: not found
Traceback (most recent call last):
  File "nix_run_setup", line 8, in <module>
    exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\\r\\n', '\\n'), __file__, 'exec'))
  File "setup.py", line 119, in <module>
    raise Exception('Applying patch failed')
Exception: Applying patch failed

I already have a fix for that locally.

@SuperSandro2000 SuperSandro2000 merged commit f44575b into NixOS:master Jan 4, 2021
@fabaff
Copy link
Member Author

fabaff commented Jan 4, 2021

I already have a fix for that locally.

Thanks

@fabaff fabaff deleted the bump-autobahn branch January 4, 2021 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants