Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vault: 1.6.0 -> 1.6.1 #108364

Merged
merged 2 commits into from Jan 6, 2021
Merged

vault: 1.6.0 -> 1.6.1 #108364

merged 2 commits into from Jan 6, 2021

Conversation

Chili-Man
Copy link
Contributor

@Chili-Man Chili-Man commented Jan 4, 2021 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Emantor
Emantor approved these changes Jan 4, 2021
View reviewed changes
Copy link
Member

@Emantor Emantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • builds on NixOS unstable
1 package built:
vault
  • binaries work in so far that --help section is output

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108364 run on x86_64-darwin 1

1 package built:
  • vault

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108364 run on x86_64-linux 1

1 package built:
  • vault

@marsam marsam mentioned this pull request Jan 6, 2021
Closed
10 tasks
marsam
marsam reviewed Jan 6, 2021
View reviewed changes
Copy link
Contributor

@marsam marsam left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you mind also updating vault-bin?

@Chili-Man
Copy link
Contributor Author

@marsam updated to also include vault-bin

@ofborg ofborg bot requested review from PsyanticY and mkaito January 6, 2021 04:09
@marsam marsam merged commit f936bda into NixOS:master Jan 6, 2021
@dotlambda
Copy link
Member

This should have been backported: #110755

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam left review comments

@Emantor Emantor Emantor approved these changes

@LnL7 LnL7 Awaiting requested review from LnL7

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

@rushmorem rushmorem Awaiting requested review from rushmorem

@PsyanticY PsyanticY Awaiting requested review from PsyanticY

@mkaito mkaito Awaiting requested review from mkaito

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Chili-Man @SuperSandro2000 @dotlambda @marsam @Emantor