Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.lwt_ppx: 2.0.1 → 2.0.2 #108373

Merged
merged 1 commit into from Jan 7, 2021
Merged

ocamlPackages.lwt_ppx: 2.0.1 → 2.0.2 #108373

merged 1 commit into from Jan 7, 2021

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Jan 4, 2021

Motivation for this change

Migration to ppxlib
Use dune 2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sternenseemann
Copy link
Member

Result of nixpkgs-review pr 108373 1

5 packages built:
  • flow
  • ocamlPackages.eliom
  • ocamlPackages.lwt_ppx
  • ocamlPackages.ocsigen-start
  • ocamlPackages.ocsigen-toolkit

@sternenseemann
Copy link
Member

The opam file requests ppxlib >= 0.16.0, but since it builds with 0.15.0 which we have at the moment, I think it's better to keep it like that. I've seen some nasty issues with having 0.15.0 and 0.16.0 being propagated in the dependency tree.

@vbgl
Copy link
Contributor Author

vbgl commented Jan 7, 2021

@GrahamcOfBorg build flow ocamlPackages.ocsigen-start ocaml-ng.ocamlPackages_4_07.earlybird

@vbgl
Copy link
Contributor Author

vbgl commented Jan 7, 2021

Indeed. Upstream seems a bit pessimistic by requiring ppxlib 0.16. It looks like it works as well with 0.15.

@vbgl vbgl merged commit 90d4109 into NixOS:master Jan 7, 2021
@vbgl vbgl deleted the ocaml-lwt_ppx_2.0.2 branch January 7, 2021 07:40
@vbgl vbgl mentioned this pull request Jan 7, 2021
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: ocaml 8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vbgl @sternenseemann