New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
haskellPackages.servant-client[-core]: jailbreak to support QuickCheck 2.14 #108362
Conversation
@r-burns Thanks for fixing this, I've confirmed this builds on Linux. @GrahamcOfBorg build cachix |
Building on Linux, so I'm merging in. Although I'm somewhat worried that aarch64 appears to be failing. |
Fwiw I was able to build cachix on aarch64, so maybe the ofborg error was spurious. I guess we will see what Hydra thinks. |
I am flabbergasted as to how this could have happened. I remember @peti distinctly saying: „Yes, the release tarball builds, so now we can merge into master.“ This override is otherwise totally fine and expected, since we had to jailbreak quite a lot of packages because of the new QuickCheck version. |
Thanks for the quick fix! |
We have a blocking issue again https://hydra.nixos.org/build/134718815 |
Huh I have disabled tests a long time ago to fix that. |
Ah, that's 20.09, going to fix it. |
Fixed, thanks @FRidh for spotting it. |
Motivation for this change
Unblocks unstable by allowing cachix to build (cc @domenkozar)
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)