Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.servant-client[-core]: jailbreak to support QuickCheck 2.14 #108362

Merged
merged 1 commit into from Jan 4, 2021

Conversation

r-burns
Copy link
Contributor

@r-burns r-burns commented Jan 4, 2021

Motivation for this change

Unblocks unstable by allowing cachix to build (cc @domenkozar)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cdepillabout
Copy link
Member

@r-burns Thanks for fixing this, I've confirmed this builds on Linux.

@GrahamcOfBorg build cachix

@cdepillabout
Copy link
Member

Building on Linux, so I'm merging in.

Although I'm somewhat worried that aarch64 appears to be failing.

@cdepillabout cdepillabout merged commit 7a6d819 into NixOS:master Jan 4, 2021
@cdepillabout
Copy link
Member

Oh and cc @maralorn and @peti about this as well.

@r-burns
Copy link
Contributor Author

r-burns commented Jan 4, 2021

Fwiw I was able to build cachix on aarch64, so maybe the ofborg error was spurious. I guess we will see what Hydra thinks.

@maralorn
Copy link
Member

maralorn commented Jan 4, 2021

I am flabbergasted as to how this could have happened.

I remember @peti distinctly saying: „Yes, the release tarball builds, so now we can merge into master.“

This override is otherwise totally fine and expected, since we had to jailbreak quite a lot of packages because of the new QuickCheck version.

@domenkozar
Copy link
Member

Thanks for the quick fix!

@FRidh
Copy link
Member

FRidh commented Jan 11, 2021

We have a blocking issue again https://hydra.nixos.org/build/134718815

@domenkozar
Copy link
Member

Huh I have disabled tests a long time ago to fix that.

@domenkozar
Copy link
Member

Ah, that's 20.09, going to fix it.

@domenkozar
Copy link
Member

Fixed, thanks @FRidh for spotting it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants