Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flatbuffers: unbreak with gcc10 #108415

Merged
merged 1 commit into from Jan 5, 2021
Merged

flatbuffers: unbreak with gcc10 #108415

merged 1 commit into from Jan 5, 2021

Conversation

rmcgibbo
Copy link
Contributor

@rmcgibbo rmcgibbo commented Jan 4, 2021

Motivation for this change

Hydra failures -- https://hydra.nixos.org/job/nixpkgs/trunk/flatbuffers.x86_64-linux. I think because of an upgrade of gcc but I didn't bisect all the way.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from teh January 4, 2021 18:53
teh
teh approved these changes Jan 4, 2021
View reviewed changes
Copy link
Contributor

@teh teh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@austinbutler
Copy link
Member

Fixes the build for me.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108415 run on x86_64-linux 1

1 package built:
  • flatbuffers

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108415 run on x86_64-darwin 1

24 packages marked as broken and skipped:
  • kodiPlugins.inputstream-adaptive
  • kodiPlugins.joystick
  • kodiPlugins.pvr-hdhomerun
  • kodiPlugins.pvr-hts
  • kodiPlugins.pvr-iptvsimple
  • kodiPlugins.steam-controller
  • kodiPlugins.vfs-libarchive
  • kodiPlugins.vfs-sftp
  • python37Packages.arviz
  • python37Packages.baselines
  • python37Packages.edward
  • python37Packages.graph_nets
  • python37Packages.mask-rcnn
  • python37Packages.optuna
  • python37Packages.pymc3
  • python37Packages.rl-coach
  • python37Packages.tensorflow
  • python37Packages.tensorflow-build
  • python37Packages.tensorflow-build_1
  • python37Packages.tensorflow-probability
  • python37Packages.tensorflowWithoutCuda
  • python37Packages.tensorflow_1
  • python37Packages.tflearn
  • python38Packages.mask-rcnn
16 packages failed to build and are new build failures:
  • python37Packages.datasets: log was empty
  • python37Packages.google_cloud_bigquery: log was empty
  • python37Packages.ibis-framework: log was empty
  • python37Packages.intake: log was empty
  • python37Packages.pyarrow: log was empty
  • python37Packages.tensorflow_2: log was empty
  • (python37Packages.tensorflow-build_2): log was empty
  • python38Packages.datasets: log was empty
  • python38Packages.google_cloud_bigquery: log was empty
  • python38Packages.intake: log was empty
  • python38Packages.pyarrow: log was empty
  • python38Packages.tensorflow_2: log was empty
  • (python38Packages.tensorflow-build_2): log was empty
  • python39Packages.tensorflow_2: log was empty
  • (python39Packages.tensorflow-build_2): log was empty
  • tts: log was empty
2 packages built:
  • arrow-cpp
  • flatbuffers

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108415 run on x86_64-linux 1

1 package built:
  • python3Packages.pyarrow

@SuperSandro2000 SuperSandro2000 merged commit acbdd4a into NixOS:master Jan 5, 2021
@rmcgibbo rmcgibbo deleted the flatbuffers branch January 5, 2021 22:03
@esotericnonsense esotericnonsense mentioned this pull request Jan 6, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teh teh teh approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rmcgibbo @austinbutler @SuperSandro2000 @teh