Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

streamlink: 1.5.0 -> 2.0.0, streamlink-twitch-gui-bin: 1.10.0 -> 1.11.0 #108370

Merged
merged 2 commits into from Jan 5, 2021
Merged

streamlink: 1.5.0 -> 2.0.0, streamlink-twitch-gui-bin: 1.10.0 -> 1.11.0 #108370

merged 2 commits into from Jan 5, 2021

Conversation

cole-h
Copy link
Member

@cole-h cole-h commented Jan 4, 2021

https://github.com/streamlink/streamlink/releases/tag/2.0.0

streamlink/streamlink@1.5.0...2.0.0

Motivation for this change

Noticed it was more than 6 months out of date, so I figured I'd update it.

Be aware that 2.0.0 contains many breaking changes. Read the changelog (above) to determine how this affects you.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from zraexy, dezgeg and Enzime January 4, 2021 06:14
Emantor
Emantor suggested changes Jan 4, 2021
View reviewed changes
Copy link
Member

@Emantor Emantor left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • builds on NixOS unstable
2 packages built:
streamlink streamlink-twitch-gui-bin
  • binary work in so far that --help section is output
  • streamlink-twitch-gui-bin will require an update, the program starts but no streams can be watched, since the older release seems to use one of the removed arguments.

@thiagokokada
Copy link
Contributor

thiagokokada commented Jan 4, 2021 •
edited

Result of nixpkgs-review pr 108370 run on x86_64-linux 1

2 packages built:
  • streamlink
  • streamlink-twitch-gui-bin

Tested with ./results/streamlink/bin/streamlink https://www.youtube.com/watch?v=Wpn9sLNg-6k best --player /run/current-system/sw/bin/mpv, seems to work great.

But like said above, streamlink-twitch-gui-bin doesn't work.

@thiagokokada
Copy link
Contributor

@cole-h Could you also update streamlink-twitch-gui-bin 🤔 ?

https://github.com/streamlink/streamlink-twitch-gui/releases/tag/v1.11.0

@cole-h
Copy link
Member Author

cole-h commented Jan 5, 2021

I prefer to have my package bumps focused only on the specified package, but I guess I can make an exception this time. Done.

@thiagokokada
Copy link
Contributor

thiagokokada commented Jan 5, 2021 •
edited

Result of nixpkgs-review pr 108370 run on x86_64-linux 1

2 packages built:
  • streamlink
  • streamlink-twitch-gui-bin

streamlink-twitch-gui-bin is working now.

@thiagokokada
Copy link
Contributor

@cole-h If you want to increase your chances for your PR to be merged, you can use: https://github.com/timokau/marvin-mk2/blob/master/USAGE.md

@ofborg ofborg bot requested a review from rileyinman January 5, 2021 20:56
@cole-h cole-h changed the title streamlink: 1.5.0 -> 2.0.0 streamlink: 1.5.0 -> 2.0.0, streamlink-twitch-gui-bin: 1.10.0 -> 1.11.0 Jan 5, 2021
@worldofpeace worldofpeace merged commit 192325c into NixOS:master Jan 5, 2021
@cole-h cole-h deleted the streamlink branch January 5, 2021 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emantor Emantor Emantor requested changes

@thiagokokada thiagokokada thiagokokada approved these changes

@zraexy zraexy Awaiting requested review from zraexy

@dezgeg dezgeg Awaiting requested review from dezgeg

@Enzime Enzime Awaiting requested review from Enzime

@rileyinman rileyinman Awaiting requested review from rileyinman

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cole-h @thiagokokada @Emantor @worldofpeace