Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.nitime: 0.8.1 -> 0.9 #108407

Merged
merged 1 commit into from Jan 18, 2021
Merged

Conversation

tfmoraes
Copy link
Contributor

@tfmoraes tfmoraes commented Jan 4, 2021

Motivation for this change

Update nitime to 0.9

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tfmoraes
Copy link
Contributor Author

tfmoraes commented Jan 4, 2021

❯ nix-shell -p nixpkgs-review --run "nixpkgs-review pr 108407"                                                           
this path will be fetched (0.04 MiB download, 0.15 MiB unpacked):
  /nix/store/200injw4k6mzr96pszd8fzxn3fj6l10l-nixpkgs-review-2.5.0
copying path '/nix/store/200injw4k6mzr96pszd8fzxn3fj6l10l-nixpkgs-review-2.5.0' from 'https://cache.nixos.org'...
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0 pull/108407/head:refs/nixpkgs-review/1
remote: Enumerating objects: 23, done.
remote: Counting objects: 100% (23/23), done.
remote: Compressing objects: 100% (9/9), done.
remote: Total 26 (delta 13), reused 15 (delta 13), pack-reused 3
Unpacking objects: 100% (26/26), 231.39 KiB | 606.00 KiB/s, done.
From https://github.com/NixOS/nixpkgs
   f0e774407c3..bf77245202a  master                -> refs/nixpkgs-review/0
   4553efaedd2..387cef6ee02  refs/pull/108407/head -> refs/nixpkgs-review/1
$ git worktree add /home/thiago/.cache/nixpkgs-review/pr-108407/nixpkgs bf77245202a01e542a38ba74a8800b80070eb28f
Preparing worktree (detached HEAD bf77245202a)
HEAD is now at bf77245202a Merge pull request #108219 from prusnak/viennarna
$ nix-env -f /home/thiago/.cache/nixpkgs-review/pr-108407/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit 387cef6ee02d44e0b70a6512b861c57db093cba2
Automatic merge went well; stopped before committing as requested
$ nix-env -f /home/thiago/.cache/nixpkgs-review/pr-108407/nixpkgs -qaP --xml --out-path --show-trace --meta
2 packages added:
python38Packages.nitime (init at 0.9) python39Packages.nitime (init at 0.9)

1 package updated:
python37Packages.nitime (0.8.1 → 0.9)

$ nix --experimental-features nix-command build --no-link --keep-going --option build-use-sandbox relaxed -f /home/thiago/.cache/nixpkgs-review/pr-108407/build.nix

Link to currently reviewing PR:
https://github.com/NixOS/nixpkgs/pull/108407

3 packages built:
python37Packages.nitime python38Packages.nitime python39Packages.nitime

@bcdarwin
Copy link
Member

bcdarwin commented Jan 5, 2021

Results of nixpkgs-review pr on NixOS:

3 packages built:
python37Packages.nitime python38Packages.nitime python39Packages.nitime

Copy link
Member

@bcdarwin bcdarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 108407 run on x86_64-linux 1

3 packages built:
  • python37Packages.nitime
  • python38Packages.nitime
  • python39Packages.nitime

@jonringer jonringer merged commit 2d32864 into NixOS:master Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants