New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.nitime: 0.8.1 -> 0.9 #108407
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❯ nix-shell -p nixpkgs-review --run "nixpkgs-review pr 108407"
this path will be fetched (0.04 MiB download, 0.15 MiB unpacked):
/nix/store/200injw4k6mzr96pszd8fzxn3fj6l10l-nixpkgs-review-2.5.0
copying path '/nix/store/200injw4k6mzr96pszd8fzxn3fj6l10l-nixpkgs-review-2.5.0' from 'https://cache.nixos.org'...
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0 pull/108407/head:refs/nixpkgs-review/1
remote: Enumerating objects: 23, done.
remote: Counting objects: 100% (23/23), done.
remote: Compressing objects: 100% (9/9), done.
remote: Total 26 (delta 13), reused 15 (delta 13), pack-reused 3
Unpacking objects: 100% (26/26), 231.39 KiB | 606.00 KiB/s, done.
From https://github.com/NixOS/nixpkgs
f0e774407c3..bf77245202a master -> refs/nixpkgs-review/0
4553efaedd2..387cef6ee02 refs/pull/108407/head -> refs/nixpkgs-review/1
$ git worktree add /home/thiago/.cache/nixpkgs-review/pr-108407/nixpkgs bf77245202a01e542a38ba74a8800b80070eb28f
Preparing worktree (detached HEAD bf77245202a)
HEAD is now at bf77245202a Merge pull request #108219 from prusnak/viennarna
$ nix-env -f /home/thiago/.cache/nixpkgs-review/pr-108407/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit 387cef6ee02d44e0b70a6512b861c57db093cba2
Automatic merge went well; stopped before committing as requested
$ nix-env -f /home/thiago/.cache/nixpkgs-review/pr-108407/nixpkgs -qaP --xml --out-path --show-trace --meta
2 packages added:
python38Packages.nitime (init at 0.9) python39Packages.nitime (init at 0.9)
1 package updated:
python37Packages.nitime (0.8.1 → 0.9)
$ nix --experimental-features nix-command build --no-link --keep-going --option build-use-sandbox relaxed -f /home/thiago/.cache/nixpkgs-review/pr-108407/build.nix
Link to currently reviewing PR:
https://github.com/NixOS/nixpkgs/pull/108407
3 packages built:
python37Packages.nitime python38Packages.nitime python39Packages.nitime |
Results of
|
bcdarwin
approved these changes
Jan 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me.
10 tasks
jonringer
approved these changes
Jan 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Result of nixpkgs-review pr 108407 run on x86_64-linux 1
3 packages built:
- python37Packages.nitime
- python38Packages.nitime
- python39Packages.nitime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update nitime to 0.9
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)