stage-0: Teardown gadget before kexec #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way on kexec the device is in a better state, and the kernel that boots next is able to use the controller. This was verified to fix an issue with kexec+gadget on the Chuwi Hi10 Pro HQ64 tablet.
Yikes, specialized code in the kexec codepath... though this is okay for now. Let's not over-generalize when we don't know what will be required in the future for abstraction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the USB controller is in a confusing state for the freshly booting kernel.
This adds a specialized code path into the kexec code path, but it's better than making the wrong abstraction.
We, anyway need to work on generic teardown later on.
Tested on an out-of-tree device.