Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

caprine-bin: init at 2.55.2 #108400

Merged
merged 1 commit into from Apr 25, 2022
Merged

caprine-bin: init at 2.55.2 #108400

merged 1 commit into from Apr 25, 2022

Conversation

ShamrockLee
Copy link
Contributor

@ShamrockLee ShamrockLee commented Jan 4, 2021 •
edited

Motivation for this change

Caprine is a third-party Facebook messenger client with a beautiful UI and features to enhance the privacy of users.
As an NodeJS-Electron application, the build-from-source attempt suffer from NPM trying to download Electron at build time, and the binary build can serve as a workaround.

Update:
Closes #90375

Known issue

Crash when doing things involving "open files with file manager", complaining:

WARNING: Kernel has no file descriptor comparison support: Function not implemented

(caprine:22216): GLib-GIO-ERROR **: 05:53:43.885: No GSettings schemas are installed on the system
Trace/breakpoint trap (core dumped)

Tried adding some Gnome-related packages to extraPagkages, but it doesn't solve the problem. It has been mentioned on NixOS Discourse.

This is common on AppImages, and is also happen when executing using appimage-run.

Nevertheless, drag-and-drop of files still work, which can serve as a workaround to the problem above.

Solved after referencing dtzWill's work on minetime and add

appimageTools.wrapType2 {
# ...
  profile = ''
    export LC_ALL=C.UTF-8
    export XDG_DATA_DIRS=${gsettings-desktop-schemas}/share/gsettings-schemas/${gsettings-desktop-schemas.name}:${gtk3}/share/gsettings-schemas/${gtk3.name}:$XDG_DATA_DIRS
  '';
# ...
}
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/) (The binary build from AppImage works. I don't have Mac with me, so I cannot test the dmg part.)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ShamrockLee ShamrockLee force-pushed the caprine-bin branch 3 times, most recently from 0bdf049 to 0795240 Compare January 4, 2021 16:26
@ShamrockLee
Copy link
Contributor Author

@GrahamcOfBorg build caprine-bin

@ShamrockLee ShamrockLee force-pushed the caprine-bin branch 2 times, most recently from c2b063e to 89d0be5 Compare January 4, 2021 18:28
@ShamrockLee ShamrockLee marked this pull request as draft January 4, 2021 21:52
@ShamrockLee ShamrockLee marked this pull request as ready for review January 5, 2021 20:06
@ShamrockLee
Copy link
Contributor Author

ShamrockLee commented Jan 5, 2021 •
edited

Have the GSetting I/O issue solved by adding

appimageTools.wrapType2 {
# ...
  profile = ''
    export LC_ALL=C.UTF-8
    export XDG_DATA_DIRS=${gsettings-desktop-schemas}/share/gsettings-schemas/${gsettings-desktop-schemas.name}:${gtk3}/share/gsettings-schemas/${gtk3.name}:$XDG_DATA_DIRS
  '';
# ...
}

@ShamrockLee ShamrockLee force-pushed the caprine-bin branch 3 times, most recently from a7946cb to 0e5fa76 Compare January 5, 2021 21:06
@ShamrockLee ShamrockLee force-pushed the caprine-bin branch 2 times, most recently from 6c7f980 to 4903b85 Compare January 10, 2021 17:41
@ShamrockLee
Copy link
Contributor Author

Apply #108938 and use lib instead of stdenv.lib.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/480

@ShamrockLee ShamrockLee force-pushed the caprine-bin branch 2 times, most recently from d229c5e to bcc304b Compare October 24, 2021 02:35
@ShamrockLee ShamrockLee mentioned this pull request Dec 3, 2021
Closed
@ShamrockLee
Copy link
Contributor Author

I have personally been using this for moths, and I think it's ready to get merged.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/653

@ShamrockLee
Copy link
Contributor Author

@ofborg build caprine-bin

@ShamrockLee ShamrockLee changed the title caprine-bin: init at 2.54.1 caprine-bin: init at 2.55.1 Dec 3, 2021
@ShamrockLee ShamrockLee changed the title caprine-bin: init at 2.55.1 caprine-bin: init at 2.55.2 Dec 22, 2021
@austinbutler
Copy link
Member

Result of nixpkgs-review pr 108400 run on x86_64-linux 1

1 package built:
  • caprine-bin

@austinbutler
Copy link
Member

Works for me on Linux and builds on macOS (although not tested there).

@ShamrockLee
Copy link
Contributor Author

Just did some renaming (appimage-x86_64 -> x86_64-appimage, build-appimage.nix -> build-from-appimage.nix ). The result hash should not be affected.

@ShamrockLee ShamrockLee force-pushed the caprine-bin branch 2 times, most recently from 993439a to 004036b Compare January 16, 2022 21:42
@austinbutler
Copy link
Member

This worked for me up until recently. If I checkout this branch and merge latest master into it it works again for me. @SuperSandro2000 seems all your requests were satisfied, mind looking again?

@SuperSandro2000 SuperSandro2000 merged commit 28da532 into NixOS:master Apr 25, 2022
@emilytrau
Copy link
Member

🥳 nice!

@ShamrockLee ShamrockLee deleted the caprine-bin branch April 26, 2022 04:11
@ShamrockLee ShamrockLee mentioned this pull request Jun 9, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

caprine
5 participants
@ShamrockLee @nixos-discourse @austinbutler @emilytrau @SuperSandro2000