Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nginx: add VOD-related modules from Kaltura #108406

Merged
merged 3 commits into from Feb 8, 2021
Merged

nginx: add VOD-related modules from Kaltura #108406

merged 3 commits into from Feb 8, 2021

Conversation

zaninime
Copy link
Contributor

@zaninime zaninime commented Jan 4, 2021

Motivation for this change

Add a collection of useful modules for video on demand distribution via nginx. I added one commit for each module.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ajs124
Copy link
Member

ajs124 commented Jan 4, 2021

secure-token also has a recent release, akamai-token-validate-module however does not.

@zaninime
Copy link
Contributor Author

zaninime commented Jan 4, 2021

Unfortunately, even though there are some recent releases for two of the three modules, some bugfixes and performance improvements didn't make into a release yet. See:

@Izorkin
Copy link
Contributor

Izorkin commented Jan 4, 2021

Possibly rename to nginxModules.: init at ..., like as in other PR? - https://github.com/NixOS/nixpkgs/commits/master/pkgs/servers/http/nginx/modules.nix

@zaninime
Copy link
Contributor Author

zaninime commented Jan 4, 2021

@Izorkin done.

@Izorkin
Copy link
Contributor

Izorkin commented Feb 8, 2021

cc @Mic92 @bhipple

@bhipple bhipple merged commit 14b6a84 into NixOS:master Feb 8, 2021
@zaninime zaninime deleted the nginx-kaltura branch July 30, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajs124 ajs124 ajs124 left review comments

@Izorkin Izorkin Izorkin approved these changes

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zaninime @ajs124 @Izorkin @bhipple