nixos/lxd: disable cgroup v2 when LXD is active #108380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patryk27
changed the title
Patryk27
force-pushed
the
fixes/lxd-cgroup-v2
branch
from
4a358e2
to
30ccbe8
Compare
SuperSandro2000
approved these changes
Jan 4, 2021
Lassulus
approved these changes
Jan 4, 2021
otavio
reviewed
Jan 4, 2021
| @@ -100,6 +100,10 @@ in | |||
| packages = [ cfg.lxcPackage ]; | |||
| }; | |||
|
|
|||
| # TODO: remove once LXD gets proper support for cgroupsv2 | |||
| # (currently most of the e.g. CPU accounting stuff doesn't work) | |||
| systemd.enableUnifiedCgroupHierarchy = false; | |||
There was a problem hiding this comment.
Is there any upstream issue to mention here?
There was a problem hiding this comment.
Unfortunately, I haven't been able to find any tracking issue - though I've found e.g. https://github.com/lxc/lxd/pull/8146, which suggests that CPU accounting should work - I guess it'll all be deployed with the next LXD's version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c768913 changed systemd to use cgroup v2 by default, which kinda-sorta broke lxd, as its support for unified hierarchy is rather poor - e.g. setting CPU limits doesn't work and I've had some issues with nested systemd instances.
Our test for LXD -
nixos/tests/lxd.nix- would've caught this (as it currently fails onmaster), but TBH I'm not sure why it wasn't ran :/