Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dwarf-therapist build on OS X #108371

Closed
wants to merge 1 commit into from
Closed

Fix dwarf-therapist build on OS X #108371

wants to merge 1 commit into from

Conversation

numinit
Copy link
Contributor

@numinit numinit commented Jan 4, 2021 •
edited

Motivation for this change

See #108324

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@numinit
Copy link
Contributor Author

numinit commented Jan 4, 2021

The next struggle is how to get Dwarf Therapist to detect our patched memory layout on OS X... it doesn't seem to be searching $(pwd)/share. Leaving this as a draft for now.

@stale
Copy link

stale bot commented Jul 4, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2021
@numinit
Copy link
Contributor Author

numinit commented Jan 2, 2023

This is probably OBE.

@numinit numinit closed this Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbradar abbradar Awaiting requested review from abbradar

@jonringer jonringer Awaiting requested review from jonringer

@bendlas bendlas Awaiting requested review from bendlas

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@numinit