kakounePlugins.kak-idris: init at 2020-12-29 #108409
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrhino
suggested changes
Jun 30, 2021
There was a problem hiding this comment.
So, there seems to be a file pkgs/applications/editors/kakoune/plugins/generated.nix containing such information, and it's made from a sibling kakoune-plugin-names file; the comment in default.nix implies that you can add the patchPhase via overrides.nix, as is done for several other packages.
Could this be adapted to use that model?
| { stdenv, fetchFromGitHub, idris2, nodejs }: | ||
| stdenv.mkDerivation { | ||
| name = "kak-idris"; | ||
| version = "2020-12-29"; |
There was a problem hiding this comment.
I think unstable- prefix is used for non-released versions
| }; | ||
|
|
||
| patchPhase = '' | ||
| sed -i 's \bnode\b ${nodejs}/bin/node g' idris.kak |
There was a problem hiding this comment.
apparently | is preferred as the alternative sed-separator if / is unworkable...
|
I'm not interested in merging this anymore. If you want to have this merged, please open a new PR and make yourself the maintainer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)