Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo-binutils: init at 0.3.3 #108410

Merged
merged 2 commits into from Jan 19, 2021
Merged

cargo-binutils: init at 0.3.3 #108410

merged 2 commits into from Jan 19, 2021

Conversation

Stupremee
Copy link
Member

@Stupremee Stupremee commented Jan 4, 2021 •
edited

Motivation for this change

cargo-binutils contains various cargo subcommands to invoke the LLVM tools that are shipped with Rust.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Stupremee
Copy link
Member Author

Result of nixpkgs-review pr 108410 run on x86_64-linux 1

1 package built:
  • cargo-binutils

doronbehar
doronbehar requested changes Jan 9, 2021
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your PR should have eventually two commits:

maintainers: add <me>
<package-name>: init at <version>

pkgs/development/tools/rust/cargo-binutils/default.nix Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108410 run on x86_64-linux 1

1 package built:
  • cargo-binutils

@SuperSandro2000 SuperSandro2000 merged commit 2c6a64d into NixOS:master Jan 19, 2021
@Stupremee Stupremee deleted the add/cargo-binutils branch January 19, 2021 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@doronbehar doronbehar doronbehar requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Stupremee @SuperSandro2000 @doronbehar