Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] profiles/hardened: Add note about potential instability #108403

Merged
merged 1 commit into from Jan 5, 2021
Merged

[20.09] profiles/hardened: Add note about potential instability #108403

merged 1 commit into from Jan 5, 2021

Conversation

talyz
Copy link
Contributor

@talyz talyz commented Jan 4, 2021

Motivation for this change

Port #108398 to stable.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@talyz
profiles/hardened: Add note about potential instability
e07e7c8 
Enabling the profile can lead to hard-to-debug issues, which should be
warned about in addition to the cost in features and performance.

See NixOS#108262 for an example.

(cherry picked from commit 0f0d5c0)
@talyz talyz requested a review from joachifm as a code owner January 4, 2021 16:35
@talyz talyz merged commit 089afe5 into NixOS:release-20.09 Jan 5, 2021
@talyz talyz deleted the 20.09-profiles_hardened_warning branch January 5, 2021 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagokokada thiagokokada thiagokokada approved these changes

@joachifm joachifm Awaiting requested review from joachifm joachifm is a code owner

Assignees
No one assigned
Labels
6.topic: nixos 8.has: documentation 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@talyz @thiagokokada