Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libsForQt5.phonon-backend-gstreamer: add missing deps #107193

Closed
wants to merge 1 commit into from
Closed

libsForQt5.phonon-backend-gstreamer: add missing deps #107193

wants to merge 1 commit into from

Conversation

eliasp
Copy link
Member

@eliasp eliasp commented Dec 19, 2020 •
edited

This fixes the majority of dependencies reported as not found, except of
CDDA support and GStreamer netbuffer support.

Motivation for this change

Get rid of warnings about dependencies not being found during the build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • (N/A, no tests) Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip" (nixpkgs-review doesn't work due to More graceful handling of nix subprocesses dieing Mic92/nixpkgs-review#146)
  • (N/A, libs only) Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (no impact, before and after is 890566576)
  • (N/A) Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@eliasp
libsForQt5.phonon-backend-gstreamer: add missing deps
07bfe68 
This fixes the majority of dependencies reported as not found, except of
CDDA support and GStreamer netbuffer support.
@eliasp eliasp requested a review from jtojnar December 19, 2020 13:57
@jtojnar
Copy link
Contributor

jtojnar commented Dec 19, 2020

Are these actual errors? CMake sometimes complains about missing pkg-config dependencies, even though they would not actually be needed unless linking statically.

@eliasp
Copy link
Member Author

eliasp commented Dec 19, 2020

You're right - those aren't real errors… just also found your post regarding this.

Closing the PR.

@eliasp eliasp closed this Dec 19, 2020
@eliasp eliasp deleted the phonon-backend-gstreamer-deps branch December 19, 2020 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eliasp @jtojnar