Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qrcodegen: init at 1.6.0 #107199

Merged
merged 1 commit into from Jan 1, 2021
Merged

qrcodegen: init at 1.6.0 #107199

merged 1 commit into from Jan 1, 2021

Conversation

mcbeth
Copy link
Contributor

@mcbeth mcbeth commented Dec 19, 2020

Motivation for this change

Library is used in notcurses #106993

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

pkgs/development/libraries/qrcodegen/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/qrcodegen/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/qrcodegen/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/qrcodegen/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/qrcodegen/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/qrcodegen/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/qrcodegen/default.nix Outdated Show resolved Hide resolved
Copy link
Member

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

It would be great if it was possible to rework the package later to build and package the shared library (.so) instead of a static object (.a) plus add the pkgconfig file.

@mcbeth
Copy link
Contributor Author

mcbeth commented Dec 19, 2020

Agreed, near as I can tell, none of those things exist in the package as deployed by upstream.

@prusnak
Copy link
Member

prusnak commented Dec 19, 2020

Agreed, near as I can tell, none of those things exist in the package as deployed by upstream.

Yup. That's why I am OK with the current form of the PR (and gave the green review). This is something for later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants