Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vicious: 2.3.1 -> 2.5.0 #107192

Merged
merged 1 commit into from Dec 30, 2020
Merged

vicious: 2.3.1 -> 2.5.0 #107192

merged 1 commit into from Dec 30, 2020

Conversation

lucc
Copy link
Contributor

@lucc lucc commented Dec 19, 2020

Motivation for this change
Things done

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)

  • Built on platform(s)

    • NixOS
    • macOS
    • other Linux distributions

  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)

  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"

  • Tested execution of all binary files (usually in ./result/bin/)

  • Determined the impact on package closure size (by running nix path-info -S before and after)

    This one is strange I have no idea why that is so:

/nix/store/ffivi9qkk49n2nwdchj6bnak5v4vzdqs-vicious-2.3.1	     193560
/nix/store/jik5niw7k3wzx3ff6mq2r4q2ghcyii85-vicious-2.5.0	   38621584

@ofborg ofborg bot added the 6.topic: lua label Dec 20, 2020
@ofborg ofborg bot requested review from Mic92 and makefu December 20, 2020 02:10
@wishfort36
Copy link
Contributor

Result of nixpkgs-review pr 107192 run on x86_64-linux 1

4 packages built:
  • lua51Packages.vicious
  • luaPackages.vicious (lua52Packages.vicious)
  • lua53Packages.vicious
  • luajitPackages.vicious

@wishfort36
Copy link
Contributor

While the filesize changes I get are nowhere near as drastic as the ones you've gotten, it seems that a lot of it is documentation:

[nix-shell:~/.cache/nixpkgs-review/pr-107192]$ du -sh results/luaPackages.vicious/lib/
496K    results/luaPackages.vicious/lib/

[nix-shell:~/.cache/nixpkgs-review/pr-107192]$ du -sh results/luaPackages.vicious/lib/lua/5.2/vicious/* | sort -h
4.0K    results/luaPackages.vicious/lib/lua/5.2/vicious/README.md
4.0K    results/luaPackages.vicious/lib/lua/5.2/vicious/TODO
4.0K    results/luaPackages.vicious/lib/lua/5.2/vicious/spawn.lua
8.0K    results/luaPackages.vicious/lib/lua/5.2/vicious/CHANGELOG.rst
12K     results/luaPackages.vicious/lib/lua/5.2/vicious/CONTRIBUTING.rst
12K     results/luaPackages.vicious/lib/lua/5.2/vicious/helpers.lua
12K     results/luaPackages.vicious/lib/lua/5.2/vicious/init.lua
12K     results/luaPackages.vicious/lib/lua/5.2/vicious/tools
16K     results/luaPackages.vicious/lib/lua/5.2/vicious/templates
20K     results/luaPackages.vicious/lib/lua/5.2/vicious/LICENSE
92K     results/luaPackages.vicious/lib/lua/5.2/vicious/docs
96K     results/luaPackages.vicious/lib/lua/5.2/vicious/contrib
180K    results/luaPackages.vicious/lib/lua/5.2/vicious/widgets

in comparison to

[/nix/store/ffivi9qkk49n2nwdchj6bnak5v4vzdqs-vicious-2.3.1]$ du -sh .
356K    .

[/nix/store/ffivi9qkk49n2nwdchj6bnak5v4vzdqs-vicious-2.3.1]$ du -sh lib/lua/5.2/vicious/* | sort -h
4.0K    lib/lua/5.2/vicious/Changes.md
4.0K    lib/lua/5.2/vicious/TODO
8.0K    lib/lua/5.2/vicious/helpers.lua
8.0K    lib/lua/5.2/vicious/init.lua
20K     lib/lua/5.2/vicious/LICENSE
32K     lib/lua/5.2/vicious/README.md
108K    lib/lua/5.2/vicious/contrib
144K    lib/lua/5.2/vicious/widgets

@Mic92 Mic92 merged commit 53b801e into NixOS:master Dec 30, 2020
@lucc lucc deleted the vicious branch December 30, 2020 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wishfort36 wishfort36 wishfort36 approved these changes

@Mic92 Mic92 Awaiting requested review from Mic92

@makefu makefu Awaiting requested review from makefu

Assignees
No one assigned
Labels
6.topic: lua 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lucc @wishfort36 @Mic92