[20.09] firefox-wayland: fix screen sharing using pipewire #107699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the fedora patches for screen sharing using pipewire got updated for Firefox 83 (pipewire was inlined there), the nixpkgs buildInput pipewire got stripped from the resulting firefox binary and so firefox was unable to actually get the shared stream from the running pipewire service. Adding pipewire to the firefox binary with `patchelf --add-needed` makes it atually get the stream from the service. Fixes: NixOS#106812
SuperSandro2000
changed the title
fadenb
approved these changes
Dec 27, 2020
|
Result of 4 packages built:
|
|
This got merged into Now we have cache misses for firefox on the stable release. Any idea on how to proceed from that? Do we need to force push to |
erictapen
pushed a commit
that referenced
this pull request
Jan 14, 2021
After the fedora patches for screen sharing using pipewire got updated for Firefox 83 (pipewire was inlined there), the nixpkgs buildInput pipewire got stripped from the resulting firefox binary and so firefox was unable to actually get the shared stream from the running pipewire service. Adding pipewire to the firefox binary with `patchelf --add-needed` makes it atually get the stream from the service. Fixes: #106812 (cherry picked from commit 62f20b0) Picked this from #107699, as the original commit was overwritten by a force-push.
|
As this was just overwritten by a force-push, I cherry-picked this on |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/nixos-20-09-channel-updated-without-firefox/10982/2 |
|
sorry did not know that. Thanks for fixing 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick from #106815
Motivation for this change
since it got fixed on
master-branch @fadenb reports, that this also works for thenixos-20.09-branchThings done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)