Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various minor standalone codechanges stolen from JGR #8440

Merged
merged 7 commits into from Dec 27, 2020

Conversation

LordAro
Copy link
Member

@LordAro LordAro commented Dec 27, 2020

Motivation / Problem

A few (unconnected) nice things pulled out of @JGRennison's fork

Description

Code cleanups
A minor optimisations for asserts
Ability to set a specific message for an assert

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

src/stdafx.h Outdated Show resolved Hide resolved
src/stdafx.h Outdated Show resolved Hide resolved
src/stdafx.h Outdated Show resolved Hide resolved
src/stdafx.h Outdated Show resolved Hide resolved
src/table/townname.h Outdated Show resolved Hide resolved
LordAro and others added 2 commits December 27, 2020 09:56
We're well past having to support non-C++11 compliant compilers now.
src/openttd.cpp Outdated Show resolved Hide resolved
@LordAro LordAro merged commit 395a5d9 into OpenTTD:master Dec 27, 2020
@LordAro LordAro deleted the various-jgr-cleanups branch December 27, 2020 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants