Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bacula: 9.6.6 -> 11.0.0 #107720

Merged
merged 1 commit into from Jan 12, 2021
Merged

bacula: 9.6.6 -> 11.0.0 #107720

merged 1 commit into from Jan 12, 2021

Conversation

freezeboy
Copy link
Contributor

Motivation for this change

Upstream update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107720 run on x86_64-linux 1

1 package built:
  • bacula

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107720 run on x86_64-darwin 1

1 package built:
  • bacula

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

@fabaff
Copy link
Member

fabaff commented Dec 28, 2020

At first glance I would say that the license is AGPLv3 and not GPL.

Bacula is licensed under the GNU Affero General Public License, version
3.0 as published by the Free Software Foundation, Inc. ("AGPLv3").

The upstream stream project also mentioned BSD-2.

The Fedora RPM uses AGPLv3 with exceptions which seems to cover the BSD licensed parts.

I assume that by mentioning both licenses we are fine (sorry, not a licensing expert here).

license = with licenses; [ agpl3Only bsd2 ];

@freezeboy
Copy link
Contributor Author

@fabaff Good catch, I didn't check that part

@fabaff
Copy link
Member

fabaff commented Dec 28, 2020

I took only a look because @SuperSandro2000 mentioned that gpl2 should not be used any longer.

@freezeboy
Copy link
Contributor Author

Oops forgot a semicolon, should be better now

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107720 run on x86_64-linux 1

1 package built:
  • bacula

@SuperSandro2000 SuperSandro2000 merged commit a588b71 into NixOS:master Jan 12, 2021
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107720 run on x86_64-darwin 1

1 package built:
  • bacula

@freezeboy freezeboy deleted the update-bacula branch January 12, 2021 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenkozar domenkozar Awaiting requested review from domenkozar

@proteansec proteansec Awaiting requested review from proteansec

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@freezeboy @SuperSandro2000 @fabaff