Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

burpsuite: ease src override #107717

Merged
merged 1 commit into from Jan 22, 2021
Merged

burpsuite: ease src override #107717

merged 1 commit into from Jan 22, 2021

Conversation

freezeboy
Copy link
Contributor

Motivation for this change

Following the discussion on discourse, I updated the software and refactored the derivation to ease future overrides for it

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107717 run on x86_64-linux 1

1 package built:
  • burpsuite

installPhase should probably contain runHook preInstall and runHook postInstall.

@freezeboy
Copy link
Contributor Author

Added the hooks

@SuperSandro2000
Copy link
Member

Why is ofborg not deting a rebuild?

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107717 run on x86_64-linux 1

1 package built:
  • burpsuite

@buckley310
Copy link
Contributor

I have a (now obsolete) PR that includes a fix for the "integrated browser" feature #100677
It's a few lines in the launch script, might be worth stealing if you like it.

@freezeboy
Copy link
Contributor Author

Just stole it ;) can you tell me if it works on your side ?

@buckley310
Copy link
Contributor

Looks good to me.

@buckley310
Copy link
Contributor

Looks like another burp update got merged. #109549
It does not include all the changes from this PR though. Maybe just rebase and change the title 🤷

@SuperSandro2000
Copy link
Member

@freezeboy please resolve the merge conflict

@freezeboy freezeboy changed the title burpsuite: 2020.1 -> 2020.12.1 burpsuite: ease src override Jan 18, 2021
@freezeboy
Copy link
Contributor Author

All done

@buckley310
Copy link
Contributor

Looks good. Works for me on nixos-unstable, and it makes the "Open Browser" feature work.

@SuperSandro2000 SuperSandro2000 merged commit 5056813 into NixOS:master Jan 22, 2021
@freezeboy freezeboy deleted the update-burpsuite branch January 22, 2021 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@freezeboy @SuperSandro2000 @buckley310