pythonPackages.demjson: fix tests, enable on Python 3.x #107718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Result of 3 packages built:
|
|
Result of 3 packages built:
|
kini
force-pushed
the
demjson/python3
branch
2 times, most recently
from
e8c61b6
to
443023b
Compare
In commit 6ba044c, the demjson package was disabled on Python 3.x with the comment that it doesn't seem to support any Python 3.x versions. But looking at the upstream repository, they do seem to attempt to support Python 3 -- it turns out the failure on our end was caused by some issue with trying to run `setup.py test` on a 2to3-using codebase with no test suite (?). In any case, this package's test suite doesn't seem to use the setuptools mechanism, so in this commit I override the checkPhase to run the upstream tests in the correct way. This fixes the build on all Python versions. EDIT 2021-01-08: rebased on top of PR NixOS#108378 which had explicitly disabled the tests on all Python versions.
|
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 3 packages built:
|
bjornfor
approved these changes
Jan 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit 6ba044c, the demjson package was
disabled on Python 3.x with the comment that it doesn't seem to support any
Python 3.x versions. But looking at the upstream repository, they do seem to
attempt to support Python 3 -- it turns out the failure on our end was caused by
some issue with trying to run
setup.py teston a 2to3-using codebase with notest suite (?).
In any case, this package's test suite doesn't seem to use the setuptools
mechanism, so in this commit I override the checkPhase to run the upstream tests
in the correct way. This fixes the build on all Python versions.
Motivation for this change
Our expression for
demjsonis broken on Python 3.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)