Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.github/workflows/editorconfig.yml: use api for list of changed files #107698

Merged
merged 1 commit into from Dec 28, 2020
Merged

.github/workflows/editorconfig.yml: use api for list of changed files #107698

merged 1 commit into from Dec 28, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Dec 27, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zowoq zowoq requested a review from Mic92 as a code owner December 27, 2020 09:08
@zowoq zowoq marked this pull request as draft December 27, 2020 20:24
@zowoq zowoq marked this pull request as ready for review December 27, 2020 20:24
@zowoq
.github/workflows/editorconfig.yml: use api for list of changed files
4084738 
faster than doing a full clone and using git diff
@zowoq zowoq merged commit 3f73b92 into NixOS:master Dec 28, 2020
@zowoq zowoq deleted the ecc-api branch December 28, 2020 07:48
@zowoq
Copy link
Contributor Author

zowoq commented Jan 3, 2021

cc @ryantm @infinisil

Just noticed that I'd missed a couple of comments on IRC. Switched editorconfig to using the API via gh as it can handle pagination so now we only need a shallow clone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 approved these changes

Assignees
No one assigned
Labels
6.topic: policy discussion 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zowoq @Mic92