Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lua: add 5.4.2 #107707

Merged
merged 1 commit into from Dec 27, 2020
Merged

lua: add 5.4.2 #107707

merged 1 commit into from Dec 27, 2020

Conversation

raboof
Copy link
Member

@raboof raboof commented Dec 27, 2020

Motivation for this change

Refs #99261

Tested with Notion, seems to work fine.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: lua label Dec 27, 2020
@SuperSandro2000
Copy link
Member

Can we remove 5.1?

@raboof
Copy link
Member Author

raboof commented Dec 27, 2020

Can we remove 5.1?

I see quite a few explicit references to lua5_1 in various places still, so I guess not yet.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107707 run on x86_64-linux 1

2 packages built:
  • lua5_4
  • lua5_4_compat

@teto
Copy link
Member

teto commented Dec 27, 2020

@SuperSandro2000 lua versioning stands on its own https://www.lua.org/versions.html. 5.1 is still very popular due to luajit so it's going to stay.

@teto teto merged commit d29ab49 into NixOS:master Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: lua 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@raboof @SuperSandro2000 @teto