Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lowdown: 0.7.4 -> 0.7.5 #107705

Merged
merged 1 commit into from Dec 28, 2020
Merged

lowdown: 0.7.4 -> 0.7.5 #107705

merged 1 commit into from Dec 28, 2020

Conversation

sternenseemann
Copy link
Member

Motivation for this change

Adds new output format.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sternenseemann
Copy link
Member Author

Result of nixpkgs-review pr 107705 run on x86_64-linux 1

8 packages built:
  • disnix
  • disnixos
  • dydisnix
  • hydra-unstable
  • lowdown
  • nix-review (nixpkgs-review)
  • nix-update
  • nixFlakes (nixUnstable)

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107705 run on x86_64-darwin 1

5 packages failed to build:
  • disnix
  • dydisnix
  • nix-update
  • nixFlakes (nixUnstable)
  • nixpkgs-review
1 package built:
  • lowdown

Probably a sandbox issue

    this derivation will be built:
      /private/tmp/nix-build-nix-2.4pre20201201_5a6ddb3.drv-0/nix-test/user-envs/store/0kdjir4fg6qaxfz4mpn9qymvdmzlxysk-foo-1.0.drv
    building '/private/tmp/nix-build-nix-2.4pre20201201_5a6ddb3.drv-0/nix-test/user-envs/store/0kdjir4fg6qaxfz4mpn9qymvdmzlxysk-foo-1.0.drv'...
    building '/private/tmp/nix-build-nix-2.4pre20201201_5a6ddb3.drv-0/nix-test/user-envs/store/p988qpmdy34dkxyr00kg213dkfy2npy2-user-environment.drv'...
    ++ nix-env -q '*'
    ++ wc -l
    + test 1 -eq 1
    + nix-env -q '*'
    + grep -q foo-1.0
    ++ /private/tmp/nix-build-nix-2.4pre20201201_5a6ddb3.drv-0/nix-test/user-envs/var/nix/profiles/test/bin/foo
    + test foo-1.0 = foo-1.0
    + nix-env -qc '*'
    + grep -q '< 2.0'
    + nix-env -qac '*'
    + grep -q '> 1.0'
    ++ nix-env -qab
    ++ wc -l
    + '[' 1 -eq 1 ']'
    + nix-env -qas
    + grep -q 'IP-  foo-1.0'
    + nix-env -qas
    + grep -q -- '---  bar-0.1'
    + nix-env --set-flag active false foo
    setting flag on 'foo-1.0'
    building '/private/tmp/nix-build-nix-2.4pre20201201_5a6ddb3.drv-0/nix-test/user-envs/store/8barkd4bfzwc6sl360xfzqjpxjxr1329-user-environment.drv'...
    + '[' -e /private/tmp/nix-build-nix-2.4pre20201201_5a6ddb3.drv-0/nix-test/user-envs/var/nix/profiles/test/bin/foo ']'
    + nix-env --set-flag active true foo
    setting flag on 'foo-1.0'
    error: --- EndOfFile --- nix-env
    unexpected EOF reading a line
make: *** [mk/lib.mk:111: tests/user-envs.sh.test] Error 1
make: *** Waiting for unfinished jobs....
ran test tests/lang.sh... [PASS]
ran test tests/gc-auto.sh... [PASS]
builder for '/nix/store/z9q7b3lj7nh5bl96507aa58cy7gya0rj-nix-2.4pre20201201_5a6ddb3.drv' failed with exit code 2
cannot build derivation '/nix/store/dkabg8anyc9xswmisxbccw5wc4mvh0j3-disnix-0.10.drv': 1 dependencies couldn't be built
error: build of '/nix/store/dkabg8anyc9xswmisxbccw5wc4mvh0j3-disnix-0.10.drv' failed

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107705 run on x86_64-linux 1

8 packages built:
  • disnix
  • disnixos
  • dydisnix
  • hydra-unstable
  • lowdown
  • nix-update
  • nixFlakes (nixUnstable)
  • nixpkgs-review

@marsam marsam merged commit 70eebb0 into NixOS:master Dec 28, 2020
@sternenseemann sternenseemann deleted the lowdown-0.7.5 branch December 28, 2020 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sternenseemann @SuperSandro2000 @marsam