Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python38: 3.8.6 -> 3.8.7, python39: 3.9.0 -> 3.9.1 #107453

Closed
wants to merge 1 commit into from
Closed

python38: 3.8.6 -> 3.8.7, python39: 3.9.0 -> 3.9.1 #107453

wants to merge 1 commit into from

Conversation

dhess
Copy link
Contributor

@dhess dhess commented Dec 23, 2020

This fixes #105038.

Motivation for this change

The versions of Python 3.8 and 3.9 in trunk are broken on macOS Big Sur. Upstream fixes have been published in 3.8.7 and 3.9.1.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dhess dhess requested a review from FRidh as a code owner December 23, 2020 10:00
@SuperSandro2000
Copy link
Member

Please target staging.

FRidh
FRidh requested changes Dec 23, 2020
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use git format-patch

@dhess
Copy link
Contributor Author

dhess commented Dec 23, 2020 •
edited

@FRidh Why? The original no-ldconfig.patches came from a mailing list, but the versions included here had to be re-generated, and were not from a mailing list. What's the point of making them look like they were?

@dhess
Copy link
Contributor Author

dhess commented Dec 27, 2020

Closing in favor of #107725, as someone else has already merged Python 3.9.1.

@dhess dhess closed this Dec 27, 2020
@rb2k rb2k mentioned this pull request Feb 5, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh requested changes

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python's ctypes broken on macOS Big Sur
3 participants
@dhess @SuperSandro2000 @FRidh