New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various minor standalone codechanges stolen from JGR #8440
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrueBrain
reviewed
Dec 27, 2020
LordAro
force-pushed
the
various-jgr-cleanups
branch
from
December 27, 2020 00:44
c2428a3
to
ca42b8c
Compare
TrueBrain
requested changes
Dec 27, 2020
We're well past having to support non-C++11 compliant compilers now.
LordAro
force-pushed
the
various-jgr-cleanups
branch
from
December 27, 2020 09:58
ca42b8c
to
5fb2378
Compare
TrueBrain
reviewed
Dec 27, 2020
CH_AUTO_LENGTH is only used when saving chunks; it makes no sense to set it for chunks without a save handler.
CH_AUTO_LENGTH is no longer used anywhere, so remove all code that depends on it.
LordAro
force-pushed
the
various-jgr-cleanups
branch
from
December 27, 2020 10:23
5fb2378
to
224b708
Compare
TrueBrain
approved these changes
Dec 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
A few (unconnected) nice things pulled out of @JGRennison's fork
Description
Code cleanups
A minor optimisations for asserts
Ability to set a specific message for an assert
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.