Codechange: Replace assert_compile macro with static_assert #8441
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
The
assert_compile
macro is now just an alias forstatic_assert
. Moreover, C++17static_assert
gains a single argument variant, so we don't have to stringify the expression ourselves.Description
A whole lot of changes to just remove 2 lines of code :)
Limitations
Doesn't use any feature macros to check whether the compiler actually supports the single argument
static_assert
variant, but we're assuming a C++17 compliant compiler at this point anyway.Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.