Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: Replace assert_compile macro with static_assert #8441

Merged
merged 1 commit into from Dec 27, 2020

Conversation

LordAro
Copy link
Member

@LordAro LordAro commented Dec 27, 2020

Motivation / Problem

The assert_compile macro is now just an alias for static_assert. Moreover, C++17 static_assert gains a single argument variant, so we don't have to stringify the expression ourselves.

Description

A whole lot of changes to just remove 2 lines of code :)

Limitations

Doesn't use any feature macros to check whether the compiler actually supports the single argument static_assert variant, but we're assuming a C++17 compliant compiler at this point anyway.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

Copy link
Member

@TrueBrain TrueBrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assumed you are capable enough to do a search/replace. I did not check this outside of stdafx.h :P

@LordAro LordAro merged commit 860c270 into OpenTTD:master Dec 27, 2020
@LordAro LordAro deleted the static-assert branch December 27, 2020 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants