vm: Remove runInWindowsVM implementation #107083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally this was meant to support other Windows versions than just Windows XP, but before I actually got a chance to implement this I left the project that I implemented this for. The code has been broken for years now and I highly doubt anyone is interested in resurrecting this (including me), so in order to make this less of a maintenance burden for everybody, let's remove it. Signed-off-by: aszlig <aszlig@nix.build>
aszlig
force-pushed
the
remove-run-in-windows-vm
branch
from
a775002
to
1152978
Compare
|
For future reference, https://git.m-labs.hk/M-Labs/wfvm seems to do something similar, but supports modern windows versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally this was meant to support other Windows versions than just Windows XP, but before I actually got a chance to implement this I left the project that I implemented this for.
The code has been broken for years now and I highly doubt anyone is interested in resurrecting this (including me), so in order to make this less of a maintenance burden for everybody, let's remove it.