Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.09] brave: 1.17.73 -> 1.18.70 #107087

Closed
wants to merge 10,000 commits into from
Closed

Conversation

buckley310
Copy link
Contributor

Motivation for this change

Backport #106718

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@JeffLabonte JeffLabonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prusnak
Copy link
Member

prusnak commented Dec 20, 2020

Please cherry pick from master using git cherry-pick -x so the commit message contains the reference to the original commit (see CONTRIBUTING.md where this is described).

@buckley310
Copy link
Contributor Author

buckley310 commented Dec 21, 2020

Sorry about that, there was some weirdness with this one and I thought I would just squash them, but missed the references.
I redid the PR just using direct cherry-picks (with -x). The actual code is unchanged.

sternenseemann and others added 20 commits December 21, 2020 10:06
Co-authored-by: Patrick Winter <patrickwinter@posteo.ch>
Previously, `vfs_snapper` was only built if `dbus` was found.
Now, `vfs_snapper` is enabled by default (on Linux)
and it requires dbus to be available:
```
Checking for dbus: not found
vfs_snapper is enabled but prerequisite dbus-1 package not found. Use
--with-shared-modules=!vfs_snapper to disable vfs_snapper support.
```

We could pass `--with-shared-modules=!vfs_snapper` to disable it,
but currently pass `--with-shared-modules=ALL`,
so add dbus as a dependency instead.
…oader-with-efi

nixos: fix "nixos-rebuild build-vm-with-bootloader" for EFI systems
nixos/manual: fix typo in virtualbox installation guide
octave: Use latest jdk & Allow 64 bit indices
smbclient does not properly link and when trying to run it it fails with
messages like:

dyld: Library not loaded: /private/tmp/nix-build-samba-4.7.12.drv-0/samba-4.7.12/bin/default/source3/libpopt-samba3-samba4.dylib
  Referenced from: result/bin/smbclient
  Reason: image not found
What's New

The highlight of this release is fixing the long-standing issue
where Firefox popups would sometimes show up in the wrong place
on multi-monitor setups (https://github.com/raboof/notion/issue/59),
thanks to great detective work by @florolf . Thanks!

* Initial implementation of _NET_FRAME_EXTENTS (raboof/notion#303) @florolf/@raboof
* Fix potential livelock in do_timer_set (raboof/notion#302) @dnr

Docs

* Add more docs to cfg_notion.lua (raboof/notion#283) @raboof

Under the hood

* Trigger release drafter from github actions (raboof/notion#304) @raboof
* Remove some colorful language (raboof/notion#296) @raboof

https://github.com/raboof/notion/releases/tag/4.0.2
@prusnak
Copy link
Member

prusnak commented Dec 24, 2020

Please fix this PR. You are trying to merge 10.000+ commits into the release branch, which is not what you want.

@buckley310
Copy link
Contributor Author

Abort!

@buckley310 buckley310 closed this Dec 24, 2020
@buckley310 buckley310 mentioned this pull request Mar 27, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet