Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rofi: support SVG icons #107156

Closed
wants to merge 1 commit into from
Closed

rofi: support SVG icons #107156

wants to merge 1 commit into from

Conversation

pbogdan
Copy link
Member

@pbogdan pbogdan commented Dec 18, 2020 •
edited

Motivation for this change

Rofi can't render SVG icons.

I don't use any rofi plugins so haven't tested those.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@teto
Copy link
Member

teto commented Dec 18, 2020

any example of an app to check this PR with ?

@pbogdan
Copy link
Member Author

pbogdan commented Dec 18, 2020

Off top my head Emacs uses an .svg icon on my system. You can also run:

$ G_MESSAGES_DEBUG=Helpers.IconFetcher rofi -show drun -show-icons

which will list supported image formats and compare before / after.

@SuperSandro2000
Copy link
Member

@pbogdan please resolve the merge conflict.

@pbogdan pbogdan closed this Jan 20, 2021
@kanashimia
Copy link
Member

Why did you close this?

@kanashimia kanashimia mentioned this pull request Jan 25, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: merge conflict 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pbogdan @teto @SuperSandro2000 @kanashimia