Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] xournalpp: 1.0.19 → 1.0.20 #107154

Merged
merged 1 commit into from Dec 20, 2020
Merged

[20.09] xournalpp: 1.0.19 → 1.0.20 #107154

merged 1 commit into from Dec 20, 2020

Conversation

alexeymuranov
Copy link
Contributor

@alexeymuranov alexeymuranov commented Dec 18, 2020 •
edited

(cherry picked from commit a5ec4f9)

Motivation for this change

Backport minor version update #107115.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sikmir @alexeymuranov
xournalpp: 1.0.19 → 1.0.20
9d0859c 
(cherry picked from commit a5ec4f9)
@drewrisinger
Copy link
Contributor

  • Diff LGTM
  • Commits LGTM
  • Builds via nix-review
1 package built:
xournalpp

$ xournalpp --version
Xournal++ 1.0.20
└──libgtk: 3.24.21
** Message: 10:34:27.379: MemoryLeak: sum 0 objects.

@ofborg ofborg bot requested review from sikmir and andrew-d December 20, 2020 00:54
@prusnak prusnak merged commit c3f4426 into NixOS:release-20.09 Dec 20, 2020
@alexeymuranov alexeymuranov deleted the backport-20_09-xournalpp branch December 20, 2020 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sikmir sikmir Awaiting requested review from sikmir

@andrew-d andrew-d Awaiting requested review from andrew-d

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alexeymuranov @drewrisinger @prusnak @sikmir