Comparing changes
Open a pull request
base repository: NixOS/nixpkgs
base: c23db78bbd47
head repository: NixOS/nixpkgs
compare: 7698aa977624
- 15 commits
- 16 files changed
- 2 contributors
Commits on Nov 30, 2020
-
lib/options: Don't show internal suboption in the manual
Initially #82897 prevented non-visible options from being rendered in the manual, but visible-but-internal options were still being recursed into. This fixes this, aligning the recurse condition here with the one in make-options-doc/default.nix
-
lib/modules: Implement module-builtin assertions
This implements assertions/warnings supported by the module system directly, instead of just being a NixOS option (see nixos/modules/misc/assertions.nix). This has the following benefits: - It allows cleanly redoing the user interface. The new implementation specifically allows disabling assertions or converting them to warnings instead. - Assertions/warnings can now be thrown easily from within submodules, which previously wasn't possible and needed workarounds.
-
-
-
lib/modules: Remove _module.checks.*.triggerPath as it's not necessary
Previously this option was thought to be necessary to avoid infinite recursion, but it actually isn't, since the check evaluation isn't fed back into the module fixed-point.
-
lib/modules: _module.check should always be internal
Honestly this option should probably just be removed
Commits on Dec 17, 2020
-
lib/modules: Introduce _module.checks.*.check
Previously the .enable option was used to encode the condition as well, which lead to some oddness: - In order to encode an assertion, one had to invert it - To disable a check, one had to mkForce it By introducing a separate .check option this is solved because: - It can be used to encode assertions - Disabling is done separately with .enable option, whose default can be overridden without a mkForce
Commits on Dec 18, 2020
-
lib/modules: Prefix mkRemovedOptionModule & co. check names
To avoid name clashes Co-authored-by: Robert Hensing <robert@roberthensing.nl>
-
Merge pull request #97023 from Infinisil/module-assertions
Module-builtin assertions, disabling assertions and submodule assertions
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff c23db78bbd47...7698aa977624