Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: c23db78bbd47
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 7698aa977624
Choose a head ref
  • 15 commits
  • 16 files changed
  • 2 contributors

Commits on Nov 30, 2020

  1. lib/options: Don't show internal suboption in the manual

    Initially #82897 prevented
    non-visible options from being rendered in the manual, but
    visible-but-internal options were still being recursed into. This fixes
    this, aligning the recurse condition here with the one in
    make-options-doc/default.nix
    infinisil committed Nov 30, 2020
    Copy the full SHA
    0b61ed7 View commit details
    Browse the repository at this point in the history
  2. lib/modules: Implement module-builtin assertions

    This implements assertions/warnings supported by the module system directly,
    instead of just being a NixOS option (see
    nixos/modules/misc/assertions.nix).
    
    This has the following benefits:
    - It allows cleanly redoing the user interface. The new
      implementation specifically allows disabling assertions or
      converting them to warnings instead.
    - Assertions/warnings can now be thrown easily from within
      submodules, which previously wasn't possible and needed workarounds.
    infinisil committed Nov 30, 2020
    Copy the full SHA
    df5ba82 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    9523df7 View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    2013134 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    1e6a84b View commit details
    Browse the repository at this point in the history
  6. Copy the full SHA
    3759a77 View commit details
    Browse the repository at this point in the history
  7. Copy the full SHA
    c4fb54e View commit details
    Browse the repository at this point in the history
  8. Copy the full SHA
    900c4a5 View commit details
    Browse the repository at this point in the history
  9. Copy the full SHA
    3e39d6e View commit details
    Browse the repository at this point in the history
  10. Copy the full SHA
    c9cc896 View commit details
    Browse the repository at this point in the history
  11. lib/modules: Remove _module.checks.*.triggerPath as it's not necessary

    Previously this option was thought to be necessary to avoid infinite
    recursion, but it actually isn't, since the check evaluation isn't fed
    back into the module fixed-point.
    infinisil committed Nov 30, 2020
    Copy the full SHA
    8dea4df View commit details
    Browse the repository at this point in the history
  12. lib/modules: _module.check should always be internal

    Honestly this option should probably just be removed
    infinisil committed Nov 30, 2020
    Copy the full SHA
    991dfcc View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2020

  1. lib/modules: Introduce _module.checks.*.check

    Previously the .enable option was used to encode the condition as well,
    which lead to some oddness:
    - In order to encode an assertion, one had to invert it
    - To disable a check, one had to mkForce it
    
    By introducing a separate .check option this is solved because:
    - It can be used to encode assertions
    - Disabling is done separately with .enable option, whose default can be
      overridden without a mkForce
    infinisil committed Dec 17, 2020
    Copy the full SHA
    767d800 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2020

  1. lib/modules: Prefix mkRemovedOptionModule & co. check names

    To avoid name clashes
    
    Co-authored-by: Robert Hensing <robert@roberthensing.nl>
    infinisil and roberth committed Dec 18, 2020
    Copy the full SHA
    a6a70d1 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #97023 from Infinisil/module-assertions

    Module-builtin assertions, disabling assertions and submodule assertions
    infinisil committed Dec 18, 2020
    Copy the full SHA
    7698aa9 View commit details
    Browse the repository at this point in the history