Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sunvox: 1.9.5d -> 1.9.6c #108634

Merged
merged 1 commit into from Jan 7, 2021
Merged

sunvox: 1.9.5d -> 1.9.6c #108634

merged 1 commit into from Jan 7, 2021

Conversation

tckmn
Copy link
Member

@tckmn tckmn commented Jan 7, 2021

Motivation for this change

The current derivation is broken because sunvox doesn't host old versions of their software on their website.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tckmn
sunvox: 1.9.5d -> 1.9.6c
297c5b3 
The current derivation is broken because sunvox doesn't host old
versions of their software on their website.
@ofborg ofborg bot requested a review from puffnfresh January 7, 2021 03:20
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108634 run on x86_64-linux 1

1 package built:
  • sunvox

@SuperSandro2000 SuperSandro2000 merged commit db5a3ef into NixOS:master Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puffnfresh puffnfresh Awaiting requested review from puffnfresh

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tckmn @SuperSandro2000