Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lean: 3.23.0 -> 3.24.0 #108636

Merged
merged 1 commit into from Jan 7, 2021
Merged

lean: 3.23.0 -> 3.24.0 #108636

merged 1 commit into from Jan 7, 2021

Conversation

ruler501
Copy link
Contributor

@ruler501 ruler501 commented Jan 7, 2021

Motivation for this change

Mathlib has updated to use the new version of lean so to stay up to date we have to update lean as well.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ruler501
lean: 3.23.0 -> 3.24.0
7a16349 
We have to update to be able to use the current version of mathlib.
@ofborg ofborg bot requested review from thoughtpolice and gebner January 7, 2021 04:07
@gebner
Copy link
Member

gebner commented Jan 7, 2021

And it builds on aarch64 again!

@gebner gebner merged commit fbd59a3 into NixOS:master Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@gebner gebner Awaiting requested review from gebner

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ruler501 @gebner @Janik-Haag