Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build error on nix-darwin #108637

Closed
wants to merge 1 commit into from
Closed

Conversation

qmx
Copy link

@qmx qmx commented Jan 7, 2021

this derivation fails on nix-darwin with a missing 'installManPage'

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

this derivation fails on nix-darwin with a missing 'installManPage'
@qmx
Copy link
Author

qmx commented Jan 7, 2021

I've applied the fix locally on my home-manager configs https://github.com/qmx/dotfiles/blob/master/home.nix#L6-L8

@SuperSandro2000
Copy link
Member

installShellFiles is already part of nativeBuildInputs where it belongs. Maybe this is not the case on stable but most definitely on master. closing.

@qmx
Copy link
Author

qmx commented Jan 7, 2021

@SuperSandro2000 should I cut a PR against stable then?

@SuperSandro2000
Copy link
Member

I don't think this is needed. The inputs where set correctly when installManPage was added qmx@ad77631.

@qmx
Copy link
Author

qmx commented Jan 7, 2021

@SuperSandro2000 well, it doesn't build on nixos-darwin on the stable channel. Do we just leave it broken then or do you have another suggestion on how to get it working out-of-the-box?

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 7, 2021

I just tested this on latest master on darwin and got a cached version from hydra so it build successfully. I am not sure what nixos-darwin does here or where the breakage for you comes from. You maybe want to double check you are using the latest version and then reach out to nixos-darwin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants