New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tab-rs: init at 0.5.5 #108622
tab-rs: init at 0.5.5 #108622
Conversation
/marvin opt-in |
Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here. |
Please squash the commits together. |
You know you can squash them in 1 click while merging on GitHub? The GitHub reviews with suggested changes is a bit silly if we need to pull and force push after approving the change. |
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 1 package built:
|
I need to remember to do this and I can easily forget that.
You can also change that locally and just force push. It is not important that you apply the suggestions. |
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
darwin patch diff --git a/pkgs/tools/misc/tab-rs/default.nix b/pkgs/tools/misc/tab-rs/default.nix
index 651e39e7948..e3bd9792c45 100644
--- a/pkgs/tools/misc/tab-rs/default.nix
+++ b/pkgs/tools/misc/tab-rs/default.nix
@@ -1,4 +1,4 @@
-{ stdenv, fetchFromGitHub, rustPlatform }:
+{ stdenv, fetchFromGitHub, rustPlatform, IOKit }:
rustPlatform.buildRustPackage rec {
pname = "tab-rs";
@@ -13,6 +13,8 @@ rustPlatform.buildRustPackage rec {
cargoSha256 = "1clpl9fi07lms0din8f9m4y6br5jg8k5xsklsqmvgdwf83wyn321";
+ buildInputs = stdenv.lib.optionals stdenv.isDarwin [ IOKit ];
+
# many tests are failing
doCheck = false;
diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix
index b6b62a11ce3..631ed016d8a 100644
--- a/pkgs/top-level/all-packages.nix
+++ b/pkgs/top-level/all-packages.nix
@@ -7755,7 +7755,9 @@ in
tabnine = callPackage ../development/tools/tabnine { };
- tab-rs = callPackage ../tools/misc/tab-rs { };
+ tab-rs = callPackage ../tools/misc/tab-rs {
+ inherit (darwin.apple_sdk.frameworks) IOKit;
+ };
t1utils = callPackage ../tools/misc/t1utils { };
|
Fair enough. Thanks for the darwin patch. I applied it and squashed the commits. |
Result of 1 package built:
|
/status needs_reviewer |
Thanks! |
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 1 package built:
|
Motivation for this change
I disabled the tests for now since too many of them are failing.
Note that the compilation is taking a long time. Maybe because of lto.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)