Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tab-rs: init at 0.5.5 #108622

Merged
merged 1 commit into from Jan 7, 2021
Merged

tab-rs: init at 0.5.5 #108622

merged 1 commit into from Jan 7, 2021

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Jan 6, 2021

Motivation for this change

Intuitive, config-driven terminal multiplexer designed for software & systems engineers

I disabled the tests for now since too many of them are failing.

Note that the compilation is taking a long time. Maybe because of lto.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bbigras
Copy link
Contributor Author

bbigras commented Jan 6, 2021

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Jan 6, 2021

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@SuperSandro2000
Copy link
Member

Please squash the commits together.

@bbigras
Copy link
Contributor Author

bbigras commented Jan 7, 2021

Please squash the commits together.

You know you can squash them in 1 click while merging on GitHub?

The GitHub reviews with suggested changes is a bit silly if we need to pull and force push after approving the change.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108622 run on x86_64-linux 1

1 package built:
  • tab-rs

@SuperSandro2000
Copy link
Member

You know you can squash them in 1 click while merging on GitHub?

I need to remember to do this and I can easily forget that.

The GitHub reviews with suggested changes is a bit silly if we need to pull and force push after approving the change.

You can also change that locally and just force push. It is not important that you apply the suggestions.

Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 7, 2021

darwin patch

diff --git a/pkgs/tools/misc/tab-rs/default.nix b/pkgs/tools/misc/tab-rs/default.nix
index 651e39e7948..e3bd9792c45 100644
--- a/pkgs/tools/misc/tab-rs/default.nix
+++ b/pkgs/tools/misc/tab-rs/default.nix
@@ -1,4 +1,4 @@
-{ stdenv, fetchFromGitHub, rustPlatform }:
+{ stdenv, fetchFromGitHub, rustPlatform, IOKit }:
 
 rustPlatform.buildRustPackage rec {
   pname = "tab-rs";
@@ -13,6 +13,8 @@ rustPlatform.buildRustPackage rec {
 
   cargoSha256 = "1clpl9fi07lms0din8f9m4y6br5jg8k5xsklsqmvgdwf83wyn321";
 
+  buildInputs = stdenv.lib.optionals stdenv.isDarwin [ IOKit ];
+
   # many tests are failing
   doCheck = false;
 
diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix
index b6b62a11ce3..631ed016d8a 100644
--- a/pkgs/top-level/all-packages.nix
+++ b/pkgs/top-level/all-packages.nix
@@ -7755,7 +7755,9 @@ in
 
   tabnine = callPackage ../development/tools/tabnine { };
 
-  tab-rs = callPackage ../tools/misc/tab-rs { };
+  tab-rs = callPackage ../tools/misc/tab-rs {
+    inherit (darwin.apple_sdk.frameworks) IOKit;
+  };
 
   t1utils = callPackage ../tools/misc/t1utils { };
 

@bbigras
Copy link
Contributor Author

bbigras commented Jan 7, 2021

I need to remember to do this and I can easily forget that.

Fair enough.

Thanks for the darwin patch. I applied it and squashed the commits.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 108622 run on x86_64-darwin 1

1 package built:
  • tab-rs

@bbigras
Copy link
Contributor Author

bbigras commented Jan 7, 2021

/status needs_reviewer

@SuperSandro2000 SuperSandro2000 merged commit 7a2a45c into NixOS:master Jan 7, 2021
@bbigras bbigras deleted the tab-rs branch January 7, 2021 22:02
@bbigras
Copy link
Contributor Author

bbigras commented Jan 7, 2021

Thanks!

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108622 run on x86_64-linux 1

1 package built:
  • tab-rs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants