Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

germinal: init at 26 #108589

Merged
merged 1 commit into from Jan 7, 2021
Merged

germinal: init at 26 #108589

merged 1 commit into from Jan 7, 2021

Conversation

AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Jan 6, 2021 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member

grahamc commented Jan 6, 2021

Hey there, can you take a look-see at #108568 (comment)?

@alyssais alyssais changed the title Updates germinal: init at 26 Jan 6, 2021
@AndersonTorres
Copy link
Member Author

Now I think it is done. I need to learn more about wrappers!

@AndersonTorres
Copy link
Member Author

Result of nixpkgs-review pr 108589 1

1 package built:
  • germinal

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108589 run on x86_64-linux 1

1 package built:
  • germinal

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 108589 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • germinal

@SuperSandro2000 SuperSandro2000 merged commit 9f823bf into NixOS:master Jan 7, 2021
@AndersonTorres AndersonTorres deleted the at1985-updates branch January 7, 2021 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukegb lukegb lukegb left review comments

@andir andir andir left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@AndersonTorres @grahamc @SuperSandro2000 @lukegb @andir