Fix #8332: aborting group drag&drop could cause crashes with vehicle drag&drop #8511
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
You could easily crash the game when aborting group drag&drop.
This is a partial backport of downstream patch:
JGRennison/OpenTTD-patches@66630ef
The other part of this patch seems somewhat pedantic, and mostly partial. There are more places in the GUI where
::Get
is done, which is not safeguarded either. See limitations how I think this could be abused. I kept this out of scope of this PR, as it would require much more changes for very unlikely edge-cases (in my opinion).Description
The selected group was not reset when drag&drop was aborted. When
after that vehicle drag&drop was successful, group drag&drop code
was still executed, causing weird behaviour or even crashes.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.