vscode-extensions.donjayamanne.githistory: init at 0.6.14 #108584
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonringer
reviewed
Jan 6, 2021
Comment on lines
+99
to
+112
| meta = { | ||
| changelog = "https://marketplace.visualstudio.com/items/donjayamanne.githistory/changelog"; | ||
| description = "Git History for Visual Studio Code"; | ||
| downloadPage = "https://marketplace.visualstudio.com/items?itemName=donjayamanne.githistory"; | ||
| homepage = "https://github.com/DonJayamanne/gitHistoryVSCode/"; | ||
| license = stdenv.lib.licenses.mit; | ||
| maintainers = [ maintainers.superherointj ]; | ||
| }; | ||
| mktplcRef = { | ||
| name = "githistory"; | ||
| publisher = "donjayamanne"; | ||
| sha256 = "11x116hzqnhgbryp2kqpki1z5mlnwxb0ly9r1513m5vgbisrsn0i"; | ||
| version = "0.6.14"; | ||
| }; |
There was a problem hiding this comment.
generally meta always comes last
Suggested change
| meta = { | |
| changelog = "https://marketplace.visualstudio.com/items/donjayamanne.githistory/changelog"; | |
| description = "Git History for Visual Studio Code"; | |
| downloadPage = "https://marketplace.visualstudio.com/items?itemName=donjayamanne.githistory"; | |
| homepage = "https://github.com/DonJayamanne/gitHistoryVSCode/"; | |
| license = stdenv.lib.licenses.mit; | |
| maintainers = [ maintainers.superherointj ]; | |
| }; | |
| mktplcRef = { | |
| name = "githistory"; | |
| publisher = "donjayamanne"; | |
| sha256 = "11x116hzqnhgbryp2kqpki1z5mlnwxb0ly9r1513m5vgbisrsn0i"; | |
| version = "0.6.14"; | |
| }; | |
| mktplcRef = { | |
| name = "githistory"; | |
| publisher = "donjayamanne"; | |
| sha256 = "11x116hzqnhgbryp2kqpki1z5mlnwxb0ly9r1513m5vgbisrsn0i"; | |
| version = "0.6.14"; | |
| }; | |
| meta = { | |
| changelog = "https://marketplace.visualstudio.com/items/donjayamanne.githistory/changelog"; | |
| description = "Git History for Visual Studio Code"; | |
| downloadPage = "https://marketplace.visualstudio.com/items?itemName=donjayamanne.githistory"; | |
| homepage = "https://github.com/DonJayamanne/gitHistoryVSCode/"; | |
| license = stdenv.lib.licenses.mit; | |
| maintainers = [ maintainers.superherointj ]; | |
| }; |
There was a problem hiding this comment.
Added "meta" first because of alphabetical order. For automation routines this is desirable. It won't change order on automated update.
jonringer
reviewed
Jan 6, 2021
Comment on lines
+99
to
+106
| meta = { | ||
| changelog = "https://marketplace.visualstudio.com/items/donjayamanne.githistory/changelog"; | ||
| description = "Git History for Visual Studio Code"; | ||
| downloadPage = "https://marketplace.visualstudio.com/items?itemName=donjayamanne.githistory"; | ||
| homepage = "https://github.com/DonJayamanne/gitHistoryVSCode/"; | ||
| license = stdenv.lib.licenses.mit; | ||
| maintainers = [ maintainers.superherointj ]; | ||
| }; |
There was a problem hiding this comment.
Suggested change
| meta = { | |
| changelog = "https://marketplace.visualstudio.com/items/donjayamanne.githistory/changelog"; | |
| description = "Git History for Visual Studio Code"; | |
| downloadPage = "https://marketplace.visualstudio.com/items?itemName=donjayamanne.githistory"; | |
| homepage = "https://github.com/DonJayamanne/gitHistoryVSCode/"; | |
| license = stdenv.lib.licenses.mit; | |
| maintainers = [ maintainers.superherointj ]; | |
| }; | |
| meta = with stdenv.lib; { | |
| changelog = "https://marketplace.visualstudio.com/items/donjayamanne.githistory/changelog"; | |
| description = "Git History for Visual Studio Code"; | |
| downloadPage = "https://marketplace.visualstudio.com/items?itemName=donjayamanne.githistory"; | |
| homepage = "https://github.com/DonJayamanne/gitHistoryVSCode/"; | |
| license = licenses.mit; | |
| maintainers = [ maintainers.superherointj ]; | |
| }; |
undefined variable 'maintainers' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/ofborg-evaluator-1/pkgs/misc/vscode-extensions/default.nix:105:27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Adding "donjayamanne.githistory" VSCode extension to Nixpkgs.
Things done
Tested in NixOS, x86-64-bit.
Note
I have added myself as a contributor here:
#108582
If that PR is not accepted this PR will fail for referencing a non-existing contributor.
I hope I have done things right. Let me know.
Thank you.