Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bupstash: init at 0.6.4 #108638

Merged
merged 1 commit into from Jan 10, 2021
Merged

bupstash: init at 0.6.4 #108638

merged 1 commit into from Jan 10, 2021

Conversation

andrewchambers
Copy link
Contributor

Motivation for this change

Adding bupstash encrypted backup software.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@andrewchambers andrewchambers mentioned this pull request Jan 7, 2021
Closed
SuperSandro2000
SuperSandro2000 requested changes Jan 7, 2021
View reviewed changes
pkgs/tools/backup/bupstash/default.nix Outdated Show resolved Hide resolved
pkgs/tools/backup/bupstash/default.nix Outdated Show resolved Hide resolved
pkgs/tools/backup/bupstash/default.nix Outdated Show resolved Hide resolved
pkgs/tools/backup/bupstash/default.nix Outdated Show resolved Hide resolved
pkgs/tools/backup/bupstash/default.nix Outdated Show resolved Hide resolved
@andrewchambers
Copy link
Contributor Author

@SuperSandro2000 Thanks for the help, I've updated your suggestions.

@andrewchambers andrewchambers changed the title bupstash: init at 0.6.3 bupstash: init at 0.6.4 Jan 7, 2021
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108638 run on x86_64-darwin 1

1 package built:
  • bupstash

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108638 run on x86_64-linux 1

1 package built:
  • bupstash

@SuperSandro2000 SuperSandro2000 merged commit b80f4f1 into NixOS:master Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk left review comments

@andir andir andir left review comments

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andrewchambers @SuperSandro2000 @danieldk @andir