python3Packages.slither-analyzer: 0.6.14 -> 0.7.0 #108610

arcz · 2021-01-06T20:17:42Z

Motivation for this change

Bump of slither-analyzer version. This required bumping crytic-compile and patching it due to old version in setup.py. Added a way to opt-out from wrapping solc since often another/specific version of solc is needed. Also, the current solc fails to build on macOS which makes slither-analyzer fail as well.

Things done

pkgs/development/python-modules/crytic-compile/default.nix

jonringer · 2021-01-06T22:19:31Z

pkgs/development/python-modules/slither-analyzer/default.nix

+  postFixup = lib.optionalString withSolc ''
    wrapProgram $out/bin/slither \
      --prefix PATH : "${lib.makeBinPath [ solc ]}"
  '';


does this application shell out to the application?

If it doesn, then you need to patch the source for it to work correctly as a python module.

it shells out

jonringer · 2021-01-06T22:20:03Z

To comply with CONTRIBUTING.md please have the commit message name be of the format

<pkg-name>: <subject-line>

for more examples, please look at https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes

in your case, the commit message should be:

python3Packages.slither-analyzer: 0.6.14 -> 0.7.0

pkgs/development/python-modules/crytic-compile/default.nix

SuperSandro2000 · 2021-01-07T16:45:21Z

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108610 run on x86_64-linux 1

6 packages built:

python37Packages.crytic-compile
python37Packages.slither-analyzer
python38Packages.crytic-compile
slither-analyzer (python38Packages.slither-analyzer)
python39Packages.crytic-compile
python39Packages.slither-analyzer

SuperSandro2000 · 2021-01-07T19:14:17Z

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108610 run on x86_64-darwin 1

4 packages failed to build and are new build failures:

python37Packages.slither-analyzer: log was empty
slither-analyzer: log was empty
(python38Packages.slither-analyzer): log was empty
python39Packages.slither-analyzer: log was empty

3 packages built:

python37Packages.crytic-compile
python38Packages.crytic-compile
python39Packages.crytic-compile

/tmp/nix-build-solc-0.7.4.drv-0/source/libsmtutil/CVC4Interface.cpp: In member function 'CVC4::Expr solidity::smtutil::CVC4Interface::toCVC4Expr(const solidity::smtutil::Expression&)':    /tmp/nix-build-solc-0.7.4.drv-0/source/libsmtutil/CVC4Interface.cpp:237:52: error: call of overloaded 'BitVector(int, size_t)' is ambiguous                                                   237 |      m_context.mkConst(CVC4::BitVector(1, size_t(0)))                                                                                                                                     |                                                    ^                                                                                                                                In file included from /nix/store/zhk68mhnl3h2yw9dxmx3z68d0y9mxnnb-cvc4-1.8/include/cvc4/expr/expr.h:61,                                                                                                      from /nix/store/zhk68mhnl3h2yw9dxmx3z68d0y9mxnnb-cvc4-1.8/include/cvc4/expr/datatype.h:37,                                                                                                  from /nix/store/zhk68mhnl3h2yw9dxmx3z68d0y9mxnnb-cvc4-1.8/include/cvc4/cvc4.h:23,                                                                                                           from /tmp/nix-build-solc-0.7.4.drv-0/source/libsmtutil/CVC4Interface.h:31,                                                                                                                  from /tmp/nix-build-solc-0.7.4.drv-0/source/libsmtutil/CVC4Interface.cpp:19:

arcz · 2021-01-08T00:19:53Z

@SuperSandro2000 I don’t think those are new build failures, it failed before this PR. One thing we could do to fix macOS build is to default withSolc to be false on darwin.

SuperSandro2000 · 2021-01-08T08:07:53Z

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108610 run on x86_64-linux 1

6 packages built:

python37Packages.crytic-compile
python37Packages.slither-analyzer
python38Packages.crytic-compile
slither-analyzer (python38Packages.slither-analyzer)
python39Packages.crytic-compile
python39Packages.slither-analyzer

SuperSandro2000 · 2021-01-10T13:56:53Z

@SuperSandro2000 I don’t think those are new build failures, it failed before this PR. One thing we could do to fix macOS build is to default withSolc to be false on darwin.

that would be fine for me. Please add a comment that solc fails to build or something.

SuperSandro2000 · 2021-01-10T23:33:23Z

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108610 run on x86_64-darwin 1

4 packages failed to build and are new build failures:

python37Packages.slither-analyzer: log https://termbin.com/yvva
slither-analyzer: log https://termbin.com/ltum
(python38Packages.slither-analyzer): log was empty
python39Packages.slither-analyzer: log https://termbin.com/g2z4

3 packages built:

python37Packages.crytic-compile
python38Packages.crytic-compile
python39Packages.crytic-compile

SuperSandro2000 · 2021-01-11T00:08:01Z

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108610 run on x86_64-linux 1

4 packages failed to build and are new build failures:

python37Packages.slither-analyzer: log https://termbin.com/urd8
slither-analyzer: log https://termbin.com/pn5y
(python38Packages.slither-analyzer): log was empty
python39Packages.slither-analyzer: log https://termbin.com/f1h8

3 packages built:

python37Packages.crytic-compile
python38Packages.crytic-compile
python39Packages.crytic-compile

arcz · 2021-02-02T13:40:45Z

@SuperSandro2000 is there still something I have to do?

SuperSandro2000 · 2021-02-03T12:28:34Z

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108610 run on x86_64-darwin 1

4 packages failed to build and are new build failures:

python37Packages.slither-analyzer: log https://termbin.com/cfbc
slither-analyzer: log https://termbin.com/ubly
(python38Packages.slither-analyzer): log was empty
python39Packages.slither-analyzer: log https://termbin.com/czuq

3 packages built:

python37Packages.crytic-compile
python38Packages.crytic-compile
python39Packages.crytic-compile

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

python37Packages.crytic-compile:

Please consider this feature to be alpha.

A substituteInPlace with an unmatched pattern got detected:

substituteStream(): WARNING: pattern 'version="0.1.9",' doesn't match anything in file 'setup.py'

Please check the offending substituteInPlace for typos or changes in source.
warning: unclear-gpl
agpl3 is a deprecated license, check if project uses agpl3Plus or agpl3Only and change meta.license accordingly.

Near pkgs/development/python-modules/crytic-compile/default.nix:28:5:

   |
28 |     license = licenses.agpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

python38Packages.crytic-compile:

Please consider this feature to be alpha.

A substituteInPlace with an unmatched pattern got detected:

substituteStream(): WARNING: pattern 'version="0.1.9",' doesn't match anything in file 'setup.py'

Please check the offending substituteInPlace for typos or changes in source.
warning: unclear-gpl
agpl3 is a deprecated license, check if project uses agpl3Plus or agpl3Only and change meta.license accordingly.

Near pkgs/development/python-modules/crytic-compile/default.nix:28:5:

   |
28 |     license = licenses.agpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

python39Packages.crytic-compile:

Please consider this feature to be alpha.

A substituteInPlace with an unmatched pattern got detected:

substituteStream(): WARNING: pattern 'version="0.1.9",' doesn't match anything in file 'setup.py'

Please check the offending substituteInPlace for typos or changes in source.
warning: unclear-gpl
agpl3 is a deprecated license, check if project uses agpl3Plus or agpl3Only and change meta.license accordingly.

Near pkgs/development/python-modules/crytic-compile/default.nix:28:5:

   |
28 |     license = licenses.agpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

SuperSandro2000 · 2021-02-03T13:47:10Z

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108610 run on x86_64-linux 1

4 packages failed to build and are new build failures:

python37Packages.slither-analyzer: log https://termbin.com/hyav
slither-analyzer: log https://termbin.com/byp6
(python38Packages.slither-analyzer): log was empty
python39Packages.slither-analyzer: log https://termbin.com/ou0h

3 packages built:

python37Packages.crytic-compile
python38Packages.crytic-compile
python39Packages.crytic-compile

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

python37Packages.crytic-compile:

Please consider this feature to be alpha.

A substituteInPlace with an unmatched pattern got detected:

substituteStream(): WARNING: pattern 'version="0.1.9",' doesn't match anything in file 'setup.py'

Please check the offending substituteInPlace for typos or changes in source.
warning: unclear-gpl
agpl3 is a deprecated license, check if project uses agpl3Plus or agpl3Only and change meta.license accordingly.

Near pkgs/development/python-modules/crytic-compile/default.nix:28:5:

   |
28 |     license = licenses.agpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

python38Packages.crytic-compile:

Please consider this feature to be alpha.

A substituteInPlace with an unmatched pattern got detected:

substituteStream(): WARNING: pattern 'version="0.1.9",' doesn't match anything in file 'setup.py'

Please check the offending substituteInPlace for typos or changes in source.
warning: unclear-gpl
agpl3 is a deprecated license, check if project uses agpl3Plus or agpl3Only and change meta.license accordingly.

Near pkgs/development/python-modules/crytic-compile/default.nix:28:5:

   |
28 |     license = licenses.agpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

python39Packages.crytic-compile:

Please consider this feature to be alpha.

A substituteInPlace with an unmatched pattern got detected:

substituteStream(): WARNING: pattern 'version="0.1.9",' doesn't match anything in file 'setup.py'

Please check the offending substituteInPlace for typos or changes in source.
warning: unclear-gpl
agpl3 is a deprecated license, check if project uses agpl3Plus or agpl3Only and change meta.license accordingly.

Near pkgs/development/python-modules/crytic-compile/default.nix:28:5:

   |
28 |     license = licenses.agpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

SuperSandro2000 · 2021-02-03T16:58:09Z

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108610 run on x86_64-linux 1

9 packages built:

python37Packages.crytic-compile
python37Packages.manticore
python37Packages.slither-analyzer
python38Packages.crytic-compile
python38Packages.manticore
slither-analyzer (python38Packages.slither-analyzer)
python39Packages.crytic-compile
python39Packages.manticore
python39Packages.slither-analyzer

SuperSandro2000 · 2021-02-04T18:23:05Z

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108610 run on x86_64-darwin 1

3 packages failed to build and are new build failures:

python37Packages.manticore: log https://termbin.com/iyr0
python38Packages.manticore: log https://termbin.com/9w7m
python39Packages.manticore: log https://termbin.com/brxw

6 packages built:

python37Packages.crytic-compile
python37Packages.slither-analyzer
python38Packages.crytic-compile
slither-analyzer (python38Packages.slither-analyzer)
python39Packages.crytic-compile
python39Packages.slither-analyzer

arcz · 2021-02-05T19:17:49Z

@SuperSandro2000 this manticore fail is unrelated to slither, I've fixed it here #112069

arcz requested review from FRidh and jonringer as code owners January 6, 2021 20:17

ofborg bot added the 6.topic: python label Jan 6, 2021

ofborg bot requested review from SuperSandro2000 and asymmetric January 6, 2021 20:26

ofborg bot added 11.by: package-maintainer 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jan 6, 2021

jonringer reviewed Jan 6, 2021

View reviewed changes

jonringer changed the title ~~slither-analyzer: 0.6.14 -> 0.7.0~~ python3Packages.slither-analyzer: 0.6.14 -> 0.7.0 Jan 6, 2021

arcz force-pushed the slither branch from 19aea83 to 856631c Compare January 6, 2021 23:35

SuperSandro2000 reviewed Jan 7, 2021

View reviewed changes

pkgs/development/python-modules/crytic-compile/default.nix Outdated Show resolved Hide resolved

arcz force-pushed the slither branch from 856631c to 8c4ccdd Compare January 7, 2021 13:51

ofborg bot requested a review from SuperSandro2000 January 7, 2021 14:14

arcz force-pushed the slither branch from 8c4ccdd to 082256e Compare January 10, 2021 15:29

arcz force-pushed the slither branch 2 times, most recently from b40322d to 6e1e924 Compare February 3, 2021 12:52

python3Packages.crytic-compile: 0.1.9 -> 0.1.12

20545ee

arcz force-pushed the slither branch from 6e1e924 to e86c802 Compare February 3, 2021 12:56

python3Packages.slither-analyzer: 0.6.14 -> 0.7.0

52f4e51

arcz force-pushed the slither branch from e86c802 to 52f4e51 Compare February 3, 2021 13:53

SuperSandro2000 merged commit e5b4782 into NixOS:master Feb 5, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

python3Packages.slither-analyzer: 0.6.14 -> 0.7.0 #108610

python3Packages.slither-analyzer: 0.6.14 -> 0.7.0 #108610

arcz commented Jan 6, 2021

jonringer Jan 6, 2021

arcz Jan 6, 2021

jonringer commented Jan 6, 2021

SuperSandro2000 commented Jan 7, 2021

SuperSandro2000 commented Jan 7, 2021 •

edited

arcz commented Jan 8, 2021

SuperSandro2000 commented Jan 8, 2021

SuperSandro2000 commented Jan 10, 2021

SuperSandro2000 commented Jan 10, 2021

SuperSandro2000 commented Jan 11, 2021

arcz commented Feb 2, 2021

SuperSandro2000 commented Feb 3, 2021

SuperSandro2000 commented Feb 3, 2021

SuperSandro2000 commented Feb 3, 2021

SuperSandro2000 commented Feb 4, 2021

arcz commented Feb 5, 2021

python3Packages.slither-analyzer: 0.6.14 -> 0.7.0 #108610

python3Packages.slither-analyzer: 0.6.14 -> 0.7.0 #108610

Conversation

arcz commented Jan 6, 2021

Motivation for this change

Things done

jonringer Jan 6, 2021

Choose a reason for hiding this comment

arcz Jan 6, 2021

Choose a reason for hiding this comment

jonringer commented Jan 6, 2021

SuperSandro2000 commented Jan 7, 2021

SuperSandro2000 commented Jan 7, 2021 • edited

arcz commented Jan 8, 2021

SuperSandro2000 commented Jan 8, 2021

SuperSandro2000 commented Jan 10, 2021

SuperSandro2000 commented Jan 10, 2021

SuperSandro2000 commented Jan 11, 2021

arcz commented Feb 2, 2021

SuperSandro2000 commented Feb 3, 2021

SuperSandro2000 commented Feb 3, 2021

SuperSandro2000 commented Feb 3, 2021

SuperSandro2000 commented Feb 4, 2021

arcz commented Feb 5, 2021

SuperSandro2000 commented Jan 7, 2021 •

edited