Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nufraw: init at 0.43-3 #108626

Merged
merged 1 commit into from Jan 7, 2021
Merged

nufraw: init at 0.43-3 #108626

merged 1 commit into from Jan 7, 2021

Conversation

asbachb
Copy link
Contributor

@asbachb asbachb commented Jan 7, 2021

In order to enable ability to generate thumbnails for raw images these packages were added:

  • nufraw is used to manipulate raw images.
  • nufraw-thumbnailer is used to generate thumbnails for raw images.

relates #108444

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 requested changes Jan 7, 2021
View reviewed changes
pkgs/applications/graphics/nufraw/default.nix Outdated Show resolved Hide resolved
pkgs/applications/graphics/nufraw/default.nix Outdated Show resolved Hide resolved
pkgs/applications/graphics/nufraw/default.nix Outdated Show resolved Hide resolved
pkgs/applications/graphics/nufraw/default.nix Outdated Show resolved Hide resolved
pkgs/applications/graphics/nufraw/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108626 run on x86_64-linux 1

2 packages blacklisted:
  • tests.nixos-functions.nixos-test
  • tests.nixos-functions.nixosTest-test
2 packages built:
  • nufraw
  • nufraw-thumbnailer

@asbachb
Copy link
Contributor Author

asbachb commented Jan 7, 2021

I guess we should remove aarch64 support for now?!

@asbachb
nufraw: init at 0.43-3
e02bf07 
`nufraw` is used to manipulate raw images.
`nufraw-thumbnailer` is used to generate thumbnails for raw images.

relates NixOS#108444
@asbachb
Copy link
Contributor Author

asbachb commented Jan 7, 2021 •
edited

replaced platforms: platforms = [ "x86_64-linux" "i686-linux" ]

@SuperSandro2000 SuperSandro2000 merged commit b6fe20a into NixOS:master Jan 7, 2021
@asbachb asbachb mentioned this pull request Jan 8, 2021
Closed
@asbachb asbachb deleted the new/nufraw branch January 8, 2021 11:43
@asbachb asbachb mentioned this pull request Jan 15, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asbachb @SuperSandro2000